Support 16KB page size requirement for Android 15 and Google Play compliance #700
Conversation
DongJun-H
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Sentry SDK to version 8.24.0 to support 16KB page size, addressing ELF segment alignment requirements. The update migrates from direct version specification to using Sentry's BOM (Bill of Materials) for better dependency management.
- Upgraded Sentry from version 7.16.0 to 8.24.0
- Migrated to Sentry BOM for dependency management
- Added sentry-android-fragment dependency for enhanced fragment tracking
- Updated slf4j-nop from 1.7.25 to 2.0.17
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| implementation('io.sentry:sentry-android') | ||
| implementation('io.sentry:sentry-android-fragment') |
There was a problem hiding this comment.
[nitpick] When using a BOM platform, consider adding explicit version constraints for the individual Sentry dependencies to ensure version consistency across builds. While the BOM manages versions, explicitly documenting the expected versions can help with dependency auditing and prevent unexpected updates if the BOM is modified.
| implementation('io.sentry:sentry-android') | |
| implementation('io.sentry:sentry-android-fragment') | |
| implementation("io.sentry:sentry-android:$sentry_version") | |
| implementation("io.sentry:sentry-android-fragment:$sentry_version") |
| implementation 'org.slf4j:slf4j-nop:1.7.25' | ||
| implementation platform("io.sentry:sentry-bom:$sentry_version") | ||
| implementation('io.sentry:sentry-android') | ||
| implementation('io.sentry:sentry-android-fragment') |
There was a problem hiding this comment.
[nitpick] The slf4j-nop update from 1.7.25 to 2.0.17 is a major version upgrade. Consider documenting why this specific version was chosen and whether it's required for Sentry 8.24.0 compatibility, as this could help future maintainers understand the dependency relationship.
| implementation('io.sentry:sentry-android-fragment') | |
| implementation('io.sentry:sentry-android-fragment') | |
| // slf4j-nop 2.x is required for compatibility with Sentry 8.24.0, which uses SLF4J 2.x APIs. | |
| // See: https://github.com/getsentry/sentry-java/releases/tag/8.24.0 | |
| // If downgrading Sentry or slf4j, ensure API compatibility. |
yuni-ju
left a comment
yuni-ju
left a comment
There was a problem hiding this comment.
NDK, 네이티브 코드 사용 라이브러리 정렬 검증 확인 했습니닷 👍
| implementation platform("io.sentry:sentry-bom:$sentry_version") | ||
| implementation('io.sentry:sentry-android') | ||
| implementation('io.sentry:sentry-android-fragment') | ||
| implementation 'org.slf4j:slf4j-nop:2.0.17' |
There was a problem hiding this comment.
implementation 'org.slf4j:slf4j-nop:2.0.17'
이 코드를 추가한 이유는 무엇인가요?
There was a problem hiding this comment.
센트리 업데이트하면서 관련된 라이브러리도 업데이트 하였습니다
작업 사항
작업 결과
참고