Skip to content

Support 16KB page size requirement for Android 15 and Google Play compliance #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DongJun-H merged 1 commit into from
Oct 29, 2025
Merged

Support 16KB page size requirement for Android 15 and Google Play compliance #700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ dependencies {
implementation project(':domain')
implementation project(':data')

def sentry_version = "7.16.0"
def sentry_version = "8.24.0"
def glide_version = "4.15.1"

// Hilt
Expand All @@ -114,8 +114,10 @@ dependencies {
implementation "com.github.bumptech.glide:glide:$glide_version"
kapt "com.github.bumptech.glide:compiler:$glide_version"
// Sentry
implementation "io.sentry:sentry-android:$sentry_version"
implementation 'org.slf4j:slf4j-nop:1.7.25'
implementation platform("io.sentry:sentry-bom:$sentry_version")
implementation('io.sentry:sentry-android')
implementation('io.sentry:sentry-android-fragment')
Comment on lines +118 to +119
Copy link

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] When using a BOM platform, consider adding explicit version constraints for the individual Sentry dependencies to ensure version consistency across builds. While the BOM manages versions, explicitly documenting the expected versions can help with dependency auditing and prevent unexpected updates if the BOM is modified.

Suggested change
implementation('io.sentry:sentry-android')
implementation('io.sentry:sentry-android-fragment')
implementation("io.sentry:sentry-android:$sentry_version")
implementation("io.sentry:sentry-android-fragment:$sentry_version")

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The slf4j-nop update from 1.7.25 to 2.0.17 is a major version upgrade. Consider documenting why this specific version was chosen and whether it's required for Sentry 8.24.0 compatibility, as this could help future maintainers understand the dependency relationship.

Suggested change
implementation('io.sentry:sentry-android-fragment')
implementation('io.sentry:sentry-android-fragment')
// slf4j-nop 2.x is required for compatibility with Sentry 8.24.0, which uses SLF4J 2.x APIs.
// See: https://github.com/getsentry/sentry-java/releases/tag/8.24.0
// If downgrading Sentry or slf4j, ensure API compatibility.

Copilot uses AI. Check for mistakes.
implementation 'org.slf4j:slf4j-nop:2.0.17'
Copy link
Member

@yuni-ju yuni-ju Oct 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation 'org.slf4j:slf4j-nop:2.0.17'

이 코드를 추가한 이유는 무엇인가요?

Copy link
Member Author

@DongJun-H DongJun-H Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

센트리 업데이트하면서 관련된 라이브러리도 업데이트 하였습니다

// Firebase
implementation 'com.google.firebase:firebase-crashlytics-ktx'
implementation 'com.google.firebase:firebase-analytics-ktx'
Expand Down