-
Notifications
You must be signed in to change notification settings - Fork 47
Reimplements Serpentis #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
just need to increase the length of the transforms for Protean and Serpentis to 'until the next sunrise'. otherwise this is basically done besides a request for me to add an alt form for Serp 4 as a recolored Gangrel warform. |
|
|
||
| cancelable = TRUE | ||
| duration_length = 1 SCENES | ||
| duration_length = 999 SCENES |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (toggled && (duration_length == 0))
return
|
hotspot hard delete - this is good to go |
| if(choice == "Obvious") | ||
| owner.st_add_stat_mod(STAT_INTIMIDATION, 2, "Serpentis") // 'reduce intimidation difficulties by two' placeholder | ||
| owner.apply_status_effect(/datum/status_effect/fortitude/three) // 'reduces all soak difficulty to 5' placeholder | ||
| ADD_TRAIT(owner, TRAIT_MASQUERADE_VIOLATING_FACE, "Serpentis") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
source for traits should be a define
| choice = tgui_alert(owner, "How do you manifest the scales along your body?", "Scales", list("Subtle", "Obvious")) | ||
| if(choice == "Obvious") | ||
| owner.st_add_stat_mod(STAT_INTIMIDATION, 2, "Serpentis") // 'reduce intimidation difficulties by two' placeholder | ||
| owner.apply_status_effect(/datum/status_effect/fortitude/three) // 'reduces all soak difficulty to 5' placeholder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this really be reusing fortitude? would those stack?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the Fortitude status effects? yeah maybe... I can perhaps make it a stamina st_stat_mod.
| pixel_w = -8 | ||
|
|
||
| /mob/living/basic/cobra/typhon | ||
| name = "Typhonic Beast" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flavcase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typhon I think is a proper noun but Beast ofc is not so I'll keep Typhonic as capital? idk
Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
| polymorph_bot.bot_cover_flags |= BOT_COVER_EMAGGED | ||
| polymorph_bot.bot_mode_flags &= ~BOT_MODE_REMOTE_ENABLED | ||
|
|
||
| new_shape.storyteller_stats = caster.storyteller_stats //DARKPACK EDIT ADD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
XeonMations
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ensure to follow fallcon's review above

About The Pull Request
after considering that maybe Serpentis needs a rework, I took a look, and it actually needs very little done to it, so im not sure what everyone was on about.
Why It's Good For The Game
closer to a finished state
Changelog
🆑
code: readds serpentis
/:cl: