Last of Flav's Firearms (Double-Barrel, Lever, & Musket)

[Stutternov]

About The Pull Request

I was requested by a friend to code these in given they were a part of a paid commission for The Final Nights and Chaz suggested I code it here given the rebase project. I did have to touch up the colors on the lever sprite to fit the others but seems to work well.

These should be the last of sprites that came in the same batch as the hunting rifle, berretta, etc.

Note: I do know someone was looking at redoing icon/inventory sprites, if it ends up being needed I can go provide new ones for these. Though these work for the moment given the current sprites used at least.

What it add???

Adds in the following:

• Double barrel shotgun, basically a slightly more expensive shotgun than the hunting shotgun but capable of firing both barrels at once. It's a bit weaker than the normal pump but can be sawn down and barrel-stuffing becomes very effective.
• Lever action rifle, chambered in .44 the lever action acts as a sort of in-between civilian firearm; fits as a niche of using the more powerful pistol round with some good bonus damage. Basically on par with the hunting rifle, slower fire rate and more punch in turn. Just get used to working it as a bolt rifle.
• Musket, chambered in .75 musketballs. This was supposed to have a complex loading style like a flintlock but I made it into a cartridge loader instead due to lack of sprites for much of it. Intended to be a one-off spawning weapon for a museum, acts like a .50 cal sniper albiet less accurate.

Double barrel (Fixed the one white pixel leftover):

Lever action:

Musket:

Why It's Good For The Game

Can see the 'about' section above for the 'niche' of each.

These were commissioned sprites from before, makes sense to add them and provides some unique variation that fit the setting. Having a pistol-caliber rifle, especially in a caliber you sometimes find but don't have too much use for besides a magnum and deagle, is a nice touch for a civilian-tier firearm.

Double barrel is sort of a staple, it fits really well. And the musket is pure map-making flavor with use behind it; 1600s ass vampire blowing your ass away.

Tl;dr - They look good sprite wise, they serve a fun niche, they fit the setting. Plus they were paid for already.

Changelog

🆑
add: Adds new double barrel shotgun w/ sprites
add: Adds new lever action .44 rifle w/ sprites
add: Adds new .75 caliber musket and cartridge's for it w/ sprites
add: Adds all new guns to the
sound: Added new fire sounds for lever action and musket
sound: Added new 'bolt'-sounds for the lever action mechanism.
/:cl:

[chazzyjazzy]

before i review:

add: Adds all new guns to the

fix that

[chazzyjazzy]

and the linter error: FAILURE #1: /obj/item/gun/ballistic/rifle/darkpack/lever using invalid worn_icon_state, "lever" in 'icons/mob/clothing/back.dmi' at code/modules/unit_tests/worn_icons.dm:63

[chazzyjazzy]

god, the whole 'vampire' vs 'darkpack' subtype thing really needs to be sorted out (in another pr).