Fixed issue with recursive calls which can cause StackOverflowError.#10535
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits intomasterfrom Feb 6, 2026
Merged
Conversation
Reverted usage of `slf4j-simple` back to `logback`, as real root-cause of hanged tests on CI was flooding error to logs.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 64 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~39e9e29c41, baseline=1.60.0-SNAPSHOT~1e93c87a84
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064838
Total [baseline] (10.863 s) : 0, 10862547
Agent [candidate] (1.074 s) : 0, 1073536
Total [candidate] (10.887 s) : 0, 10886998
section appsec
Agent [baseline] (1.24 s) : 0, 1240367
Total [baseline] (10.982 s) : 0, 10981734
Agent [candidate] (1.237 s) : 0, 1237423
Total [candidate] (10.96 s) : 0, 10959997
section iast
Agent [baseline] (1.231 s) : 0, 1231412
Total [baseline] (11.213 s) : 0, 11213342
Agent [candidate] (1.232 s) : 0, 1231801
Total [candidate] (11.158 s) : 0, 11158429
section profiling
Agent [baseline] (1.189 s) : 0, 1189277
Total [baseline] (10.907 s) : 0, 10907079
Agent [candidate] (1.197 s) : 0, 1197020
Total [candidate] (11.009 s) : 0, 11009235
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~39e9e29c41, baseline=1.60.0-SNAPSHOT~1e93c87a84
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (629.753 ms) : 0, 629753
BytebuddyAgent [candidate] (632.061 ms) : 0, 632061
AgentMeter [baseline] (28.911 ms) : 0, 28911
AgentMeter [candidate] (29.3 ms) : 0, 29300
GlobalTracer [baseline] (258.271 ms) : 0, 258271
GlobalTracer [candidate] (260.599 ms) : 0, 260599
AppSec [baseline] (32.841 ms) : 0, 32841
AppSec [candidate] (33.483 ms) : 0, 33483
Debugger [baseline] (63.422 ms) : 0, 63422
Debugger [candidate] (61.519 ms) : 0, 61519
Remote Config [baseline] (608.592 µs) : 0, 609
Remote Config [candidate] (641.159 µs) : 0, 641
Telemetry [baseline] (10.721 ms) : 0, 10721
Telemetry [candidate] (14.728 ms) : 0, 14728
Flare Poller [baseline] (3.767 ms) : 0, 3767
Flare Poller [candidate] (4.601 ms) : 0, 4601
section appsec
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (659.386 ms) : 0, 659386
BytebuddyAgent [candidate] (657.627 ms) : 0, 657627
AgentMeter [baseline] (11.933 ms) : 0, 11933
AgentMeter [candidate] (11.919 ms) : 0, 11919
GlobalTracer [baseline] (258.865 ms) : 0, 258865
GlobalTracer [candidate] (258.19 ms) : 0, 258190
IAST [baseline] (25.268 ms) : 0, 25268
IAST [candidate] (25.224 ms) : 0, 25224
AppSec [baseline] (167.762 ms) : 0, 167762
AppSec [candidate] (167.536 ms) : 0, 167536
Debugger [baseline] (67.316 ms) : 0, 67316
Debugger [candidate] (67.045 ms) : 0, 67045
Remote Config [baseline] (671.217 µs) : 0, 671
Remote Config [candidate] (655.333 µs) : 0, 655
Telemetry [baseline] (9.103 ms) : 0, 9103
Telemetry [candidate] (9.104 ms) : 0, 9104
Flare Poller [baseline] (3.655 ms) : 0, 3655
Flare Poller [candidate] (3.642 ms) : 0, 3642
section iast
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.203 ms) : 0, 1203
BytebuddyAgent [baseline] (795.018 ms) : 0, 795018
BytebuddyAgent [candidate] (795.466 ms) : 0, 795466
AgentMeter [baseline] (11.283 ms) : 0, 11283
AgentMeter [candidate] (11.24 ms) : 0, 11240
GlobalTracer [baseline] (248.402 ms) : 0, 248402
GlobalTracer [candidate] (248.53 ms) : 0, 248530
IAST [baseline] (26.906 ms) : 0, 26906
IAST [candidate] (26.908 ms) : 0, 26908
AppSec [baseline] (35.448 ms) : 0, 35448
AppSec [candidate] (32.069 ms) : 0, 32069
Debugger [baseline] (65.295 ms) : 0, 65295
Debugger [candidate] (68.522 ms) : 0, 68522
Remote Config [baseline] (541.916 µs) : 0, 542
Remote Config [candidate] (541.459 µs) : 0, 541
Telemetry [baseline] (8.671 ms) : 0, 8671
Telemetry [candidate] (8.634 ms) : 0, 8634
Flare Poller [baseline] (3.449 ms) : 0, 3449
Flare Poller [candidate] (3.508 ms) : 0, 3508
section profiling
crashtracking [baseline] (1.21 ms) : 0, 1210
crashtracking [candidate] (1.227 ms) : 0, 1227
BytebuddyAgent [baseline] (681.518 ms) : 0, 681518
BytebuddyAgent [candidate] (686.504 ms) : 0, 686504
AgentMeter [baseline] (8.79 ms) : 0, 8790
AgentMeter [candidate] (8.781 ms) : 0, 8781
GlobalTracer [baseline] (215.816 ms) : 0, 215816
GlobalTracer [candidate] (217.569 ms) : 0, 217569
AppSec [baseline] (32.406 ms) : 0, 32406
AppSec [candidate] (32.702 ms) : 0, 32702
Debugger [baseline] (68.102 ms) : 0, 68102
Debugger [candidate] (67.9 ms) : 0, 67900
Remote Config [baseline] (591.144 µs) : 0, 591
Remote Config [candidate] (601.073 µs) : 0, 601
Telemetry [baseline] (8.793 ms) : 0, 8793
Telemetry [candidate] (8.905 ms) : 0, 8905
Flare Poller [baseline] (3.686 ms) : 0, 3686
Flare Poller [candidate] (3.74 ms) : 0, 3740
ProfilingAgent [baseline] (98.595 ms) : 0, 98595
ProfilingAgent [candidate] (98.787 ms) : 0, 98787
Profiling [baseline] (99.163 ms) : 0, 99163
Profiling [candidate] (99.35 ms) : 0, 99350
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~39e9e29c41, baseline=1.60.0-SNAPSHOT~1e93c87a84
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1076445
Total [baseline] (8.797 s) : 0, 8797299
Agent [candidate] (1.067 s) : 0, 1067060
Total [candidate] (8.72 s) : 0, 8719646
section iast
Agent [baseline] (1.239 s) : 0, 1239094
Total [baseline] (9.357 s) : 0, 9356657
Agent [candidate] (1.229 s) : 0, 1228915
Total [candidate] (9.371 s) : 0, 9370845
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~39e9e29c41, baseline=1.60.0-SNAPSHOT~1e93c87a84
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (633.721 ms) : 0, 633721
BytebuddyAgent [candidate] (629.44 ms) : 0, 629440
AgentMeter [baseline] (29.408 ms) : 0, 29408
AgentMeter [candidate] (28.893 ms) : 0, 28893
GlobalTracer [baseline] (260.824 ms) : 0, 260824
GlobalTracer [candidate] (258.179 ms) : 0, 258179
AppSec [baseline] (33.478 ms) : 0, 33478
AppSec [candidate] (32.949 ms) : 0, 32949
Debugger [baseline] (63.918 ms) : 0, 63918
Debugger [candidate] (60.37 ms) : 0, 60370
Remote Config [baseline] (619.041 µs) : 0, 619
Remote Config [candidate] (617.707 µs) : 0, 618
Telemetry [baseline] (12.985 ms) : 0, 12985
Telemetry [candidate] (13.877 ms) : 0, 13877
Flare Poller [baseline] (4.646 ms) : 0, 4646
Flare Poller [candidate] (6.105 ms) : 0, 6105
section iast
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (801.034 ms) : 0, 801034
BytebuddyAgent [candidate] (794.089 ms) : 0, 794089
AgentMeter [baseline] (11.5 ms) : 0, 11500
AgentMeter [candidate] (11.207 ms) : 0, 11207
GlobalTracer [baseline] (249.81 ms) : 0, 249810
GlobalTracer [candidate] (248.096 ms) : 0, 248096
IAST [baseline] (27.263 ms) : 0, 27263
IAST [candidate] (26.967 ms) : 0, 26967
AppSec [baseline] (34.062 ms) : 0, 34062
AppSec [candidate] (34.012 ms) : 0, 34012
Debugger [baseline] (66.076 ms) : 0, 66076
Debugger [candidate] (65.486 ms) : 0, 65486
Remote Config [baseline] (529.813 µs) : 0, 530
Remote Config [candidate] (540.13 µs) : 0, 540
Telemetry [baseline] (8.698 ms) : 0, 8698
Telemetry [candidate] (8.59 ms) : 0, 8590
Flare Poller [baseline] (3.48 ms) : 0, 3480
Flare Poller [candidate] (3.533 ms) : 0, 3533
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 3 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~39e9e29c41, baseline=1.60.0-SNAPSHOT~1e93c87a84
dateFormat X
axisFormat %s
section baseline
no_agent (18.041 ms) : 17860, 18222
. : milestone, 18041,
appsec (18.512 ms) : 18328, 18696
. : milestone, 18512,
code_origins (17.579 ms) : 17407, 17751
. : milestone, 17579,
iast (17.69 ms) : 17513, 17867
. : milestone, 17690,
profiling (18.554 ms) : 18370, 18738
. : milestone, 18554,
tracing (17.858 ms) : 17682, 18034
. : milestone, 17858,
section candidate
no_agent (18.433 ms) : 18244, 18623
. : milestone, 18433,
appsec (18.628 ms) : 18442, 18814
. : milestone, 18628,
code_origins (18.771 ms) : 18580, 18961
. : milestone, 18771,
iast (17.784 ms) : 17605, 17963
. : milestone, 17784,
profiling (18.489 ms) : 18302, 18676
. : milestone, 18489,
tracing (18.629 ms) : 18441, 18817
. : milestone, 18629,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~39e9e29c41, baseline=1.60.0-SNAPSHOT~1e93c87a84
dateFormat X
axisFormat %s
section baseline
no_agent (1.193 ms) : 1182, 1205
. : milestone, 1193,
iast (3.096 ms) : 3051, 3141
. : milestone, 3096,
iast_FULL (5.915 ms) : 5856, 5974
. : milestone, 5915,
iast_GLOBAL (3.493 ms) : 3444, 3542
. : milestone, 3493,
profiling (2.191 ms) : 2172, 2211
. : milestone, 2191,
tracing (1.787 ms) : 1771, 1802
. : milestone, 1787,
section candidate
no_agent (1.172 ms) : 1160, 1183
. : milestone, 1172,
iast (3.03 ms) : 2994, 3067
. : milestone, 3030,
iast_FULL (5.774 ms) : 5717, 5831
. : milestone, 5774,
iast_GLOBAL (3.281 ms) : 3238, 3324
. : milestone, 3281,
profiling (1.987 ms) : 1970, 2004
. : milestone, 1987,
tracing (1.792 ms) : 1775, 1809
. : milestone, 1792,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~39e9e29c41, baseline=1.60.0-SNAPSHOT~1e93c87a84
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (2.503 ms) : 2448, 2557
. : milestone, 2503,
iast (2.243 ms) : 2175, 2312
. : milestone, 2243,
iast_GLOBAL (2.278 ms) : 2209, 2347
. : milestone, 2278,
profiling (2.096 ms) : 2040, 2151
. : milestone, 2096,
tracing (2.065 ms) : 2011, 2118
. : milestone, 2065,
section candidate
no_agent (1.467 ms) : 1455, 1478
. : milestone, 1467,
appsec (3.778 ms) : 3558, 3997
. : milestone, 3778,
iast (2.245 ms) : 2177, 2314
. : milestone, 2245,
iast_GLOBAL (2.283 ms) : 2214, 2352
. : milestone, 2283,
profiling (2.081 ms) : 2025, 2136
. : milestone, 2081,
tracing (2.062 ms) : 2009, 2116
. : milestone, 2062,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~39e9e29c41, baseline=1.60.0-SNAPSHOT~1e93c87a84
dateFormat X
axisFormat %s
section baseline
no_agent (15.512 s) : 15512000, 15512000
. : milestone, 15512000,
appsec (15.136 s) : 15136000, 15136000
. : milestone, 15136000,
iast (18.168 s) : 18168000, 18168000
. : milestone, 18168000,
iast_GLOBAL (17.848 s) : 17848000, 17848000
. : milestone, 17848000,
profiling (15.35 s) : 15350000, 15350000
. : milestone, 15350000,
tracing (14.575 s) : 14575000, 14575000
. : milestone, 14575000,
section candidate
no_agent (15.566 s) : 15566000, 15566000
. : milestone, 15566000,
appsec (15.103 s) : 15103000, 15103000
. : milestone, 15103000,
iast (17.797 s) : 17797000, 17797000
. : milestone, 17797000,
iast_GLOBAL (17.753 s) : 17753000, 17753000
. : milestone, 17753000,
profiling (15.025 s) : 15025000, 15025000
. : milestone, 15025000,
tracing (14.835 s) : 14835000, 14835000
. : milestone, 14835000,
|
dougqh
approved these changes
Feb 6, 2026
bric3
approved these changes
Feb 6, 2026
dd-java-agent/instrumentation/vertx/vertx-web/vertx-web-3.4/build.gradle
Show resolved
Hide resolved
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Restore stable, green CI by fixing the actual root cause instead of masking the symptoms.
Additional Notes
We have test
:dd-java-agent:instrumentation:vertx:vertx-web:vertx-web-3.4:testthat would hang on CI with ~10% probability.The initial hypothesis was that the issue was caused by using legacy
Logbacklibrary. After switching toslf4j-simple, however, the test started hanging inside Gradle code while attempting to write to the console.Given that:
CI runs Gradle in parallel, and the environment is virtualized, it’s likely there are limits around concurrent console output. This surfaced the real issue: the test was flooding the logs due to an infinite recursion during error handling.
All previous attempts effectively hid the problem instead of fixing it. This is further supported by the fact that we run ~200k tests using
Logbackwithout any hanging issues.Technical Details
The infinite recursion happens in
WrapRunnableAsNewTaskInstrumentationduring Vertx server shutdown:Fixed by adding guards against recursive calls.