-
Notifications
You must be signed in to change notification settings - Fork 324
Preserve the function relative address when parsing a crash #10544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve the function relative address when parsing a crash #10544
Conversation
zhengyu123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~d600b71b0f, baseline=1.60.0-SNAPSHOT~cffe9c6085
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.074 s) : 0, 1073791
Total [baseline] (10.969 s) : 0, 10969346
Agent [candidate] (1.081 s) : 0, 1081281
Total [candidate] (10.985 s) : 0, 10984548
section appsec
Agent [baseline] (1.247 s) : 0, 1247298
Total [baseline] (11.162 s) : 0, 11161641
Agent [candidate] (1.238 s) : 0, 1237939
Total [candidate] (11.051 s) : 0, 11051056
section iast
Agent [baseline] (1.231 s) : 0, 1231385
Total [baseline] (11.202 s) : 0, 11202457
Agent [candidate] (1.238 s) : 0, 1238370
Total [candidate] (11.157 s) : 0, 11157427
section profiling
Agent [baseline] (1.19 s) : 0, 1189621
Total [baseline] (11.052 s) : 0, 11051862
Agent [candidate] (1.192 s) : 0, 1192452
Total [candidate] (10.989 s) : 0, 10988909
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~d600b71b0f, baseline=1.60.0-SNAPSHOT~cffe9c6085
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (633.34 ms) : 0, 633340
BytebuddyAgent [candidate] (638.302 ms) : 0, 638302
AgentMeter [baseline] (29.161 ms) : 0, 29161
AgentMeter [candidate] (29.39 ms) : 0, 29390
GlobalTracer [baseline] (259.922 ms) : 0, 259922
GlobalTracer [candidate] (261.498 ms) : 0, 261498
AppSec [baseline] (33.199 ms) : 0, 33199
AppSec [candidate] (33.341 ms) : 0, 33341
Debugger [baseline] (61.778 ms) : 0, 61778
Debugger [candidate] (63.556 ms) : 0, 63556
Remote Config [baseline] (623.707 µs) : 0, 624
Remote Config [candidate] (613.905 µs) : 0, 614
Telemetry [baseline] (11.345 ms) : 0, 11345
Telemetry [candidate] (10.775 ms) : 0, 10775
Flare Poller [baseline] (7.69 ms) : 0, 7690
Flare Poller [candidate] (6.844 ms) : 0, 6844
section appsec
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (662.762 ms) : 0, 662762
BytebuddyAgent [candidate] (656.878 ms) : 0, 656878
AgentMeter [baseline] (11.995 ms) : 0, 11995
AgentMeter [candidate] (11.941 ms) : 0, 11941
GlobalTracer [baseline] (260.304 ms) : 0, 260304
GlobalTracer [candidate] (258.475 ms) : 0, 258475
IAST [baseline] (25.46 ms) : 0, 25460
IAST [candidate] (25.127 ms) : 0, 25127
AppSec [baseline] (168.872 ms) : 0, 168872
AppSec [candidate] (168.084 ms) : 0, 168084
Debugger [baseline] (67.636 ms) : 0, 67636
Debugger [candidate] (67.402 ms) : 0, 67402
Remote Config [baseline] (662.139 µs) : 0, 662
Remote Config [candidate] (677.262 µs) : 0, 677
Telemetry [baseline] (9.244 ms) : 0, 9244
Telemetry [candidate] (9.177 ms) : 0, 9177
Flare Poller [baseline] (3.623 ms) : 0, 3623
Flare Poller [candidate] (3.616 ms) : 0, 3616
section iast
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (795.565 ms) : 0, 795565
BytebuddyAgent [candidate] (800.145 ms) : 0, 800145
AgentMeter [baseline] (11.242 ms) : 0, 11242
AgentMeter [candidate] (11.295 ms) : 0, 11295
GlobalTracer [baseline] (248.396 ms) : 0, 248396
GlobalTracer [candidate] (249.224 ms) : 0, 249224
IAST [baseline] (26.833 ms) : 0, 26833
IAST [candidate] (26.998 ms) : 0, 26998
AppSec [baseline] (32.894 ms) : 0, 32894
AppSec [candidate] (33.014 ms) : 0, 33014
Debugger [baseline] (67.128 ms) : 0, 67128
Debugger [candidate] (68.319 ms) : 0, 68319
Remote Config [baseline] (542.019 µs) : 0, 542
Remote Config [candidate] (551.559 µs) : 0, 552
Telemetry [baseline] (8.77 ms) : 0, 8770
Telemetry [candidate] (8.668 ms) : 0, 8668
Flare Poller [baseline] (3.486 ms) : 0, 3486
Flare Poller [candidate] (3.502 ms) : 0, 3502
section profiling
crashtracking [baseline] (1.209 ms) : 0, 1209
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (680.992 ms) : 0, 680992
BytebuddyAgent [candidate] (683.092 ms) : 0, 683092
AgentMeter [baseline] (8.806 ms) : 0, 8806
AgentMeter [candidate] (8.82 ms) : 0, 8820
GlobalTracer [baseline] (215.664 ms) : 0, 215664
GlobalTracer [candidate] (216.176 ms) : 0, 216176
AppSec [baseline] (32.302 ms) : 0, 32302
AppSec [candidate] (32.346 ms) : 0, 32346
Debugger [baseline] (67.387 ms) : 0, 67387
Debugger [candidate] (67.587 ms) : 0, 67587
Remote Config [baseline] (591.477 µs) : 0, 591
Remote Config [candidate] (597.078 µs) : 0, 597
Telemetry [baseline] (8.871 ms) : 0, 8871
Telemetry [candidate] (8.904 ms) : 0, 8904
Flare Poller [baseline] (3.753 ms) : 0, 3753
Flare Poller [candidate] (3.801 ms) : 0, 3801
ProfilingAgent [baseline] (100.059 ms) : 0, 100059
ProfilingAgent [candidate] (99.98 ms) : 0, 99980
Profiling [baseline] (100.638 ms) : 0, 100638
Profiling [candidate] (100.549 ms) : 0, 100549
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~d600b71b0f, baseline=1.60.0-SNAPSHOT~cffe9c6085
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1066482
Total [baseline] (8.782 s) : 0, 8782455
Agent [candidate] (1.064 s) : 0, 1064288
Total [candidate] (8.732 s) : 0, 8732195
section iast
Agent [baseline] (1.232 s) : 0, 1232336
Total [baseline] (9.417 s) : 0, 9416754
Agent [candidate] (1.233 s) : 0, 1232948
Total [candidate] (9.394 s) : 0, 9394325
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~d600b71b0f, baseline=1.60.0-SNAPSHOT~cffe9c6085
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (630.016 ms) : 0, 630016
BytebuddyAgent [candidate] (628.94 ms) : 0, 628940
AgentMeter [baseline] (28.958 ms) : 0, 28958
AgentMeter [candidate] (28.939 ms) : 0, 28939
GlobalTracer [baseline] (258.036 ms) : 0, 258036
GlobalTracer [candidate] (257.883 ms) : 0, 257883
AppSec [baseline] (32.967 ms) : 0, 32967
AppSec [candidate] (32.771 ms) : 0, 32771
Debugger [baseline] (61.747 ms) : 0, 61747
Debugger [candidate] (61.014 ms) : 0, 61014
Remote Config [baseline] (613.174 µs) : 0, 613
Remote Config [candidate] (624.969 µs) : 0, 625
Telemetry [baseline] (11.302 ms) : 0, 11302
Telemetry [candidate] (11.467 ms) : 0, 11467
Flare Poller [baseline] (6.125 ms) : 0, 6125
Flare Poller [candidate] (6.017 ms) : 0, 6017
section iast
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (796.245 ms) : 0, 796245
BytebuddyAgent [candidate] (796.234 ms) : 0, 796234
AgentMeter [baseline] (11.268 ms) : 0, 11268
AgentMeter [candidate] (11.28 ms) : 0, 11280
GlobalTracer [baseline] (249.321 ms) : 0, 249321
GlobalTracer [candidate] (248.846 ms) : 0, 248846
IAST [baseline] (26.88 ms) : 0, 26880
IAST [candidate] (27.002 ms) : 0, 27002
AppSec [baseline] (30.875 ms) : 0, 30875
AppSec [candidate] (33.251 ms) : 0, 33251
Debugger [baseline] (68.532 ms) : 0, 68532
Debugger [candidate] (66.95 ms) : 0, 66950
Remote Config [baseline] (551.165 µs) : 0, 551
Remote Config [candidate] (552.478 µs) : 0, 552
Telemetry [baseline] (8.601 ms) : 0, 8601
Telemetry [candidate] (8.729 ms) : 0, 8729
Flare Poller [baseline] (3.487 ms) : 0, 3487
Flare Poller [candidate] (3.517 ms) : 0, 3517
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~d600b71b0f, baseline=1.60.0-SNAPSHOT~cffe9c6085
dateFormat X
axisFormat %s
section baseline
no_agent (19.304 ms) : 19104, 19504
. : milestone, 19304,
appsec (19.521 ms) : 19320, 19722
. : milestone, 19521,
code_origins (17.77 ms) : 17594, 17946
. : milestone, 17770,
iast (17.551 ms) : 17374, 17727
. : milestone, 17551,
profiling (19.406 ms) : 19209, 19603
. : milestone, 19406,
tracing (17.709 ms) : 17533, 17885
. : milestone, 17709,
section candidate
no_agent (17.918 ms) : 17743, 18093
. : milestone, 17918,
appsec (19.429 ms) : 19229, 19630
. : milestone, 19429,
code_origins (17.536 ms) : 17364, 17709
. : milestone, 17536,
iast (17.706 ms) : 17528, 17883
. : milestone, 17706,
profiling (19.658 ms) : 19457, 19859
. : milestone, 19658,
tracing (17.66 ms) : 17484, 17836
. : milestone, 17660,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~d600b71b0f, baseline=1.60.0-SNAPSHOT~cffe9c6085
dateFormat X
axisFormat %s
section baseline
no_agent (1.196 ms) : 1185, 1208
. : milestone, 1196,
iast (3.127 ms) : 3085, 3169
. : milestone, 3127,
iast_FULL (5.62 ms) : 5565, 5676
. : milestone, 5620,
iast_GLOBAL (3.338 ms) : 3285, 3391
. : milestone, 3338,
profiling (2.091 ms) : 2071, 2110
. : milestone, 2091,
tracing (1.778 ms) : 1763, 1793
. : milestone, 1778,
section candidate
no_agent (1.189 ms) : 1177, 1200
. : milestone, 1189,
iast (3.245 ms) : 3199, 3291
. : milestone, 3245,
iast_FULL (5.847 ms) : 5788, 5906
. : milestone, 5847,
iast_GLOBAL (3.559 ms) : 3494, 3624
. : milestone, 3559,
profiling (2.072 ms) : 2054, 2090
. : milestone, 2072,
tracing (1.852 ms) : 1837, 1868
. : milestone, 1852,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~d600b71b0f, baseline=1.60.0-SNAPSHOT~cffe9c6085
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.508 ms) : 2454, 2563
. : milestone, 2508,
iast (2.25 ms) : 2181, 2318
. : milestone, 2250,
iast_GLOBAL (2.296 ms) : 2227, 2365
. : milestone, 2296,
profiling (2.077 ms) : 2022, 2131
. : milestone, 2077,
tracing (2.074 ms) : 2020, 2127
. : milestone, 2074,
section candidate
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (2.512 ms) : 2457, 2566
. : milestone, 2512,
iast (2.254 ms) : 2185, 2322
. : milestone, 2254,
iast_GLOBAL (2.298 ms) : 2229, 2367
. : milestone, 2298,
profiling (2.094 ms) : 2038, 2150
. : milestone, 2094,
tracing (2.06 ms) : 2006, 2113
. : milestone, 2060,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~d600b71b0f, baseline=1.60.0-SNAPSHOT~cffe9c6085
dateFormat X
axisFormat %s
section baseline
no_agent (15.649 s) : 15649000, 15649000
. : milestone, 15649000,
appsec (14.961 s) : 14961000, 14961000
. : milestone, 14961000,
iast (18.113 s) : 18113000, 18113000
. : milestone, 18113000,
iast_GLOBAL (17.661 s) : 17661000, 17661000
. : milestone, 17661000,
profiling (15.016 s) : 15016000, 15016000
. : milestone, 15016000,
tracing (14.645 s) : 14645000, 14645000
. : milestone, 14645000,
section candidate
no_agent (15.685 s) : 15685000, 15685000
. : milestone, 15685000,
appsec (14.584 s) : 14584000, 14584000
. : milestone, 14584000,
iast (18.114 s) : 18114000, 18114000
. : milestone, 18114000,
iast_GLOBAL (17.857 s) : 17857000, 17857000
. : milestone, 17857000,
profiling (14.691 s) : 14691000, 14691000
. : milestone, 14691000,
tracing (14.931 s) : 14931000, 14931000
. : milestone, 14931000,
|
efe2687
into
master
What Does This Do
Keep the function relative address as part of the
functionname payload when parsing the hs_errExample:
becomes:
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]