This repository was archived by the owner on Nov 26, 2019. It is now read-only.
[MBGCLT-225]fix sample code's targetsdkversion to 28 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lj-huang
commented
May 15, 2019
| package="jp.mobage.am.shellapp.sample" | ||
| xmlns:tools="http://schemas.android.com/tools"> | ||
|
|
||
| <uses-permission android:name="android.permission.INTERNET" /> |
Author
There was a problem hiding this comment.
これらのpermissionは、SDKのmanifestに宣言していたので、不要だと思い削除しました。
lj-huang
force-pushed
the
lj/targetsdkversion28
branch
from
cbf8b80 to
2770e3d
Compare
doa11
reviewed
May 15, 2019
| implementation 'com.google.firebase:firebase-messaging:17.1.0' | ||
| implementation 'com.firebase:firebase-jobdispatcher:0.8.5' | ||
| implementation project(':MobageShellAppSDKAndroid') | ||
| implementation 'com.google.android.gms:play-services-base:16.1.0' |
Contributor
There was a problem hiding this comment.
こちらなんで追加したか気になります。確か古いものなので使ってない認識です。
あとちなみに以下を消した理由は成果物のgradleに記載したから で認識あってますでしょうか？
implementation 'com.google.android.gms:play-services-ads:15.0.1'
implementation 'com.google.firebase:firebase-messaging:17.1.0'
implementation 'com.firebase:firebase-jobdispatcher:0.8.5'
Author
There was a problem hiding this comment.
こちらなんで追加したか気になります。確か古いものなので使ってない認識です。
import com.google.android.gms.common.ConnectionResult;
import com.google.android.gms.common.GooglePlayServicesUtil;
この辺りで使われてますね。
あとちなみに以下を消した理由は成果物のgradleに記載したから で認識あってますでしょうか？
はい、 各 gradle moduleは、自分が依存している libしか管理しません というポリシーで消しました。
doa11
approved these changes
May 15, 2019
added 2 commits
July 8, 2019 17:39
This reverts commit 0227110.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@doa11
対応
ShellAppSDK for AndroidのTargetSdkVersion28対応におけるサンプルの更新
TODO