Skip to content
This repository was archived by the owner on Nov 26, 2019. It is now read-only.
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 75 additions & 0 deletions android/MobageShellAppSDKSampleApp/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
# Built application files
*.apk
*.ap_
*.aab

# Files for the ART/Dalvik VM
*.dex

# Java class files
*.class

# Generated files
bin/
gen/
out/
release/

# Gradle files
.gradle/
build/

# Local configuration file (sdk path, etc)
local.properties

# Proguard folder generated by Eclipse
proguard/

# Log Files
*.log

# Android Studio Navigation editor temp files
.navigation/

# Android Studio captures folder
captures/

# IntelliJ
*.iml
.idea/

# Keystore files
# Uncomment the following lines if you do not want to check your keystore files in.
#*.jks
#*.keystore

# External native build folder generated in Android Studio 2.2 and later
.externalNativeBuild

# Google Services (e.g. APIs or Firebase)
# google-services.json

# Freeline
freeline.py
freeline/
freeline_project_description.json

# fastlane
fastlane/report.xml
fastlane/Preview.html
fastlane/screenshots
fastlane/test_output
fastlane/readme.md

# Version control
vcs.xml

# lint
lint/intermediates/
lint/generated/
lint/outputs/
lint/tmp/
# lint/reports/

# MobageShellAppSDK
MobageShellAppSDKAndroid/*
2 changes: 1 addition & 1 deletion android/MobageShellAppSDKSampleApp/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ buildscript {
jcenter()
}
dependencies {
classpath 'com.android.tools.build:gradle:3.0.0'
classpath 'com.android.tools.build:gradle:3.4.0'
}
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#Wed Apr 10 15:27:10 PDT 2013
#Tue May 14 18:33:22 JST 2019
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-4.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-5.1.1-all.zip
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
apply plugin: 'com.android.application'

android {
compileSdkVersion 26
buildToolsVersion "26.0.3"
compileSdkVersion 28

defaultConfig {
minSdkVersion 14
targetSdkVersion 26
targetSdkVersion 28
versionCode 1
versionName "1.0.0"

Expand All @@ -24,9 +23,6 @@ android {
}

dependencies {
compile project(':MobageShellAppSDKAndroid')

implementation 'com.google.android.gms:play-services-ads:15.0.1'
implementation 'com.google.firebase:firebase-messaging:17.1.0'
implementation 'com.firebase:firebase-jobdispatcher:0.8.5'
implementation project(':MobageShellAppSDKAndroid')
implementation 'com.google.android.gms:play-services-base:16.1.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちらなんで追加したか気になります。確か古いものなので使ってない認識です。

あとちなみに以下を消した理由は成果物のgradleに記載したから で認識あってますでしょうか?

implementation 'com.google.android.gms:play-services-ads:15.0.1'
implementation 'com.google.firebase:firebase-messaging:17.1.0'	
implementation 'com.firebase:firebase-jobdispatcher:0.8.5'

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちらなんで追加したか気になります。確か古いものなので使ってない認識です。

https://github.com/DeNADev/MobageShellAppSDKSampleApp/blob/master/android/MobageShellAppSDKSampleApp/shellAppSDKSample/src/main/java/com/mobage/android/shellappsdk/sample/SACUtils.java#L27-L28

import com.google.android.gms.common.ConnectionResult;
import com.google.android.gms.common.GooglePlayServicesUtil;

この辺りで使われてますね。

あとちなみに以下を消した理由は成果物のgradleに記載したから で認識あってますでしょうか?

はい、 各 gradle moduleは、自分が依存している libしか管理しません というポリシーで消しました。

}
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,6 @@
package="jp.mobage.am.shellapp.sample"
xmlns:tools="http://schemas.android.com/tools">

<uses-permission android:name="android.permission.INTERNET" />
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これらのpermissionは、SDKのmanifestに宣言していたので、不要だと思い削除しました。

<uses-permission android:name="android.permission.ACCESS_WIFI_STATE" />
<uses-permission android:name="android.permission.READ_PHONE_STATE" />
<uses-permission android:name="com.android.vending.BILLING" />

<application
android:allowBackup="true"
android:label="@string/app_name"
Expand Down
Binary file not shown.