Skip to content

Fix: Add duplicate name check in rename_image to prevent 500 errors #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maubreville merged 2 commits into from
Sep 26, 2025
Merged

Fix: Add duplicate name check in rename_image to prevent 500 errors #142

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96301f6
Initial plan
Copilot Sep 26, 2025
4f38f53
Fix: Add duplicate name check in rename_image to prevent 500 errors
Copilot Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions exact/exact/images/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1716,6 +1716,13 @@ def rename_image(request, imageset_id):


if 'edit_set' in imageset.get_perms(request.user):
# Check if an image with the new name already exists in the imageset
existing_image = Image.objects.filter(Q(name=newName)|Q(filename=newstem+filenameext),
image_set=imageset).exclude(id=image.id).first()
if existing_image is not None:
# Image with this name already exists, redirect without changes
return redirect(reverse('images:view_imageset', args=(imageset_id,)))

if os.path.exists(os.path.join(imageset.root_path(),image.name)):
os.rename(os.path.join(imageset.root_path(),image.name),
os.path.join(imageset.root_path(),newName))
Expand Down