Open
Conversation
VirginiaDooley
force-pushed
the
hotfix/validate-linkedin
branch
3 times, most recently
from
463a57c to
73ddc78
Compare
symroe
requested changes
Jul 16, 2024
ynr/apps/people/helpers.py
Outdated
|
|
||
|
|
||
| def clean_linkedin_url(url): | ||
| if not re.match(r"^https?://(www\.)?linkedin\.com/in/[\w-]+/?$", url): |
Member
There was a problem hiding this comment.
Can you update this as per the insta PR to use urlparse to match the domain(s) and path?
Contributor
Author
There was a problem hiding this comment.
Sorry, I thought I had! Will do.
symroe
approved these changes
Jul 16, 2024
Contributor
Author
|
@sym We have several linkedin urls that are redirects, for example: FYI, we have 5,556 instances of a LinkedIn |
VirginiaDooley
force-pushed
the
hotfix/validate-linkedin
branch
from
c4a34fc to
b9d4747
Compare
VirginiaDooley
force-pushed
the
hotfix/validate-linkedin
branch
from
b9d4747 to
5ea0157
Compare
VirginiaDooley
force-pushed
the
hotfix/validate-linkedin
branch
from
9c60a28 to
5ea0157
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change