fix: Allowed multiple update callbacks on an AttrR#128
Merged
Conversation
Contributor
evvaaaa
commented
Mar 10, 2025
- Transports will add an update callback, so if we don't allow for multiple then running them simultaneously won't work.
- The controller level can add their own now too.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
==========================================
+ Coverage 90.52% 90.56% +0.03%
==========================================
Files 41 41
Lines 1920 1928 +8
==========================================
+ Hits 1738 1746 +8
Misses 182 182 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Looks good, I'll check if with fastcs-eiger |
Contributor
Author
I imagine it wouldn't work because of other changes. We've just found a bug in the last PR where now the controller that comes through in handlers is always the top level one. |
evvaaaa
commented
Mar 10, 2025
GDYendell
requested changes
Mar 10, 2025
8b3e2ea to
a8ccffd
Compare
* Transports will add an update callback, so if we don't allow for multiple then running them simultaneously won't work. * The controller level can add their own now too.
a8ccffd to
a4c4499
Compare
GDYendell
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.