Skip to content

Ensure group is passed when binding commands#171

Merged
GDYendell merged 2 commits intomainfrom
command_group
Jul 25, 2025
Merged

Ensure group is passed when binding commands#171
GDYendell merged 2 commits intomainfrom
command_group

Conversation

@JamesOHeaDLS
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.28%. Comparing base (e3e15ea) to head (1a89888).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
- Coverage   92.58%   92.28%   -0.30%     
==========================================
  Files          40       40              
  Lines        1968     2009      +41     
==========================================
+ Hits         1822     1854      +32     
- Misses        146      155       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GDYendell
Copy link
Contributor

GDYendell commented Jul 24, 2025

@JamesOHeaDLS could you update this test to pass group to UnboundCommand and assert that the Command has the same group set?

@JamesOHeaDLS
Copy link
Contributor Author

Hi @GDYendell
I think this does what you are after. At least, if I remove the fix to cs_methods.py it fails
Thanks,
James

@GDYendell GDYendell merged commit 225dca8 into main Jul 25, 2025
17 of 18 checks passed
@GDYendell GDYendell deleted the command_group branch July 25, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants