Skip to content

Ensure group is passed when binding commands #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GDYendell merged 2 commits into from
Jul 25, 2025
Merged

Ensure group is passed when binding commands #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bea912
Ensure group is passed when binding commands
JamesOHeaDLS Jul 23, 2025
1a89888
Add test for ensuring group is passed when binding commands
JamesOHeaDLS Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/fastcs/cs_methods.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ def _validate(self, fn: UnboundCommandCallback[Controller_T]) -> None:
raise FastCSException("Command method cannot have arguments")

def bind(self, controller: Controller_T) -> Command:
return Command(MethodType(self.fn, controller))
return Command(MethodType(self.fn, controller), group=self.group)

def __call__(self):
raise method_not_bound_error
Expand Down
4 changes: 3 additions & 1 deletion tests/test_cs_methods.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ async def do_nothing(self):
async def do_nothing_with_arg(self, arg):
pass

unbound_command = UnboundCommand(TestController.do_nothing)
unbound_command = UnboundCommand(TestController.do_nothing, group="Test")

with pytest.raises(NotImplementedError):
await unbound_command()
Expand All @@ -57,6 +57,8 @@ async def do_nothing_with_arg(self, arg):
Command(TestController().do_nothing_with_arg) # type: ignore

command = unbound_command.bind(TestController())
# Test that group is passed when binding commands
assert command.group == "Test"

await command()

Expand Down
Loading