Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1905 +/- ##
==========================================
- Coverage 99.03% 99.02% -0.02%
==========================================
Files 305 304 -1
Lines 11519 11569 +50
==========================================
+ Hits 11408 11456 +48
- Misses 111 113 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
This will break any of these beamlines if they're not using numtracker see https://diamondlightsource.slack.com/archives/C051NDJH6BZ/p1770382254715929 |
Contributor
Author
|
Discussed with @tpoliaw, he's going to pick this up given it has wider ramifications than I realised |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1902
I have already discussed the b16 changes with @douglaswinter and the beamline is not using them anyway.
For the changes to i13-1 we will also need to update https://github.com/DiamondLightSource/imaging-bluesky/blame/b72c6a9eed984cfa4e0b233df90685810b140af1/scripts/plans.py#L250
Instructions to reviewer on how to test:
dodal connect ixxfor the changed beamlines gives the same output on this branch and mainChecks for reviewer
dodal connect ${BEAMLINE}