Skip to content

Add WatchableAsyncStatus support to the xbpm_feedback status#1928

Merged
rtuck99 merged 3 commits intomainfrom
mx-bluesky_1362_progress_monitoring
Feb 19, 2026
Merged

Add WatchableAsyncStatus support to the xbpm_feedback status#1928
rtuck99 merged 3 commits intomainfrom
mx-bluesky_1362_progress_monitoring

Conversation

@rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented Feb 18, 2026

Required for

This makes the xbpm_feedback device trigger() method return WatchableAsyncStatus which enables blueapi to send ProgressEvents regarding it.

Instructions to reviewer on how to test:

  1. Tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.05%. Comparing base (004332f) to head (726fc95).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1928   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files         312      312           
  Lines       11750    11754    +4     
=======================================
+ Hits        11639    11643    +4     
  Misses        111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rtuck99 rtuck99 marked this pull request as ready for review February 18, 2026 12:08
@rtuck99 rtuck99 requested a review from a team as a code owner February 18, 2026 12:08
Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@rtuck99 rtuck99 enabled auto-merge (squash) February 19, 2026 11:38
@rtuck99 rtuck99 merged commit ec5fc8d into main Feb 19, 2026
7 checks passed
@rtuck99 rtuck99 deleted the mx-bluesky_1362_progress_monitoring branch February 19, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments