hyperion-supervisor monitoring of hyperion-blueapi progress + alerts for no beam and other cases where hyperion is stuck#1633
Open
rtuck99 wants to merge 9 commits into1564_unable_to_serialize_load_centre_collectfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1564_unable_to_serialize_load_centre_collect #1633 +/- ##
================================================================================
+ Coverage 92.86% 92.90% +0.04%
================================================================================
Files 156 157 +1
Lines 8698 8768 +70
================================================================================
+ Hits 8077 8146 +69
- Misses 621 622 +1
🚀 New features to boost your workflow:
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Depends on
hyperion-supervisorcannot runload_centre_collectunable to serializeparameter_model_version#1564Link to dodal PR (if required):
(remember to update
pyproject.tomlwith the dodal commit tag if you need it for tests to pass!)When running in blueapi mode,
hyperion-supervisornow monitors the progress of the call tohyperion-blueapi.If
hyperion-blueapimakes no progress for 10 minutes:hyperion-blueapiis waiting for xbpm feedback (no beam), then hyperion will raise an alert every 10 minutes until beam feedback is okhyperion-blueapiis not waiting for xbpm feedback, then hyperion will raise an error alert, abort the current collection and hand the baton back.Instructions to reviewer on how to test:
Checks for reviewer