Don't move gonio or aperture after hyperion gridscan. Rename XRC to gridscan#1627
Merged
Don't move gonio or aperture after hyperion gridscan. Rename XRC to gridscan#1627
Conversation
olliesilvester
changed the title
olliesilvester
changed the title
olliesilvester
changed the title
…1624_hyperion_doesnt_xrc_in_pin_tip
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1627 +/- ##
==========================================
- Coverage 92.86% 92.81% -0.05%
==========================================
Files 153 153
Lines 8646 8642 -4
==========================================
- Hits 8029 8021 -8
- Misses 617 621 +4
🚀 New features to boost your workflow:
|
olliesilvester
commented
Feb 12, 2026
| "mx_bluesky.common.experiment_plans.change_aperture_then_move_plan.change_aperture_then_move_to_xtal", | ||
| autospec=True, | ||
| ) | ||
| def test_pin_tip_centre_then_xray_centre_moves_to_centre_of_first_flyscan_result( |
Contributor
Author
There was a problem hiding this comment.
Removed this test instead of fixing it since the plan is about to be removed (and that's why codecov is sad)
olliesilvester
added
bug
rtuck99
reviewed
Feb 12, 2026
Contributor
There was a problem hiding this comment.
minor nit: would be nice to call it _grid_detect_and_gridscan_plan()
rtuck99
approved these changes
Feb 12, 2026
Contributor
rtuck99
left a comment
rtuck99
left a comment
There was a problem hiding this comment.
Approved, only one minor comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1624
Also renames "XRC" to "gridscan" in a few places. Gridscan should refer to the actual scan, while XRC should refer to the "move gonio to xtal center" part.
Instructions to reviewer on how to test:
Checks for reviewer