Bump deps/fbitset from 1f1a3db to c3ca474#2
Conversation
Bumps [deps/fbitset](https://github.com/DrudgeCAS/fbitset) from `1f1a3db` to `c3ca474`. - [Commits](DrudgeCAS/fbitset@1f1a3db...c3ca474) --- updated-dependencies: - dependency-name: deps/fbitset dependency-version: c3ca47404ac195a96f87ccf94ea66b3fc593cff5 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
|
@copilot Identify the cause of the failed build. It's probably due to the fbitset update. Note that I do want to use the latest commit of fbitset (c3ca474). If the build error can be fixed within libparenth without touching fbitset, fix it. Otherwise, do not touch the code, but generate a markdown file that shows me how to fix the issue within fbitset. |
|
@chenpeizhi I've opened a new pull request, #4, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: chenpeizhi <8114085+chenpeizhi@users.noreply.github.com>
Co-authored-by: chenpeizhi <8114085+chenpeizhi@users.noreply.github.com>
…rom int to size_t) Co-authored-by: chenpeizhi <8114085+chenpeizhi@users.noreply.github.com>
Co-authored-by: chenpeizhi <8114085+chenpeizhi@users.noreply.github.com>
Fix libparenth compatibility with fbitset c3ca474 (Size type change from int to size_t)
There was a problem hiding this comment.
Pull Request Overview
This PR updates the fbitset dependency from commit 1f1a3db to c3ca474, incorporating upstream changes including CI migration, Catch2 v3.11 upgrade, and API modifications to the Fbitset template parameters.
- Updated
fbitsetsubmodule to latest commit - Adapted code to new
Fbitsettemplate signature with additional type parameters - Refactored bitset operations to use
count()instead of relying onfind_last()return values
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| deps/fbitset | Updated submodule commit hash to c3ca474 |
| test/matrixchain.cpp | Updated stream operator template to match new Fbitset signature with Size, L, and E parameters |
| include/libparenth.hpp | Replaced negative index checks with explicit count() validation for bitset operations |
| .gitignore | Added CodeQL-related build directories to ignore list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dependabot
bot
deleted the
dependabot/submodules/deps/fbitset-c3ca474
branch
Bumps deps/fbitset from
1f1a3dbtoc3ca474.Commits
c3ca474ci: Migrate from CircleCI to GitHub Actions (#1) and upgrade to Catch2 v3.113a54534Update README012dbafAdd default value for the number of in-place limbsfdb3300Update the Size type definitionb6432dbRework the iterator internals847c6beClarify impact of size on equality and hashing327e2acFix optimization by loop unrolling1f923feAdd pointer access to the limbse944c3bMove core access methods to the base class91fd55eRemove duplicated number of limbs utilityDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)