Skip to content

Fix libparenth compatibility with fbitset c3ca474 (Size type change from int to size_t)#4

Merged
chenpeizhi merged 6 commits intodependabot/submodules/deps/fbitset-c3ca474from
copilot/sub-pr-2
Nov 10, 2025
Merged

Fix libparenth compatibility with fbitset c3ca474 (Size type change from int to size_t)#4
chenpeizhi merged 6 commits intodependabot/submodules/deps/fbitset-c3ca474from
copilot/sub-pr-2

Conversation

Copy link
Contributor

Copilot AI commented Nov 9, 2025

  • Identify the root cause of the build failure
  • Fix the stream insertion operator template in test/matrixchain.cpp to match all three template parameters (Size N, typename L, typename E)
  • Fix unsigned comparison bug in libparenth.hpp caused by fbitset Size type change from int to size_t
  • Build and test the fix - all tests pass
  • Update .gitignore to exclude build directory
  • Untrack _codeql_build_dir and add to .gitignore

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 3 commits November 10, 2025 00:03
Co-authored-by: chenpeizhi <8114085+chenpeizhi@users.noreply.github.com>
Co-authored-by: chenpeizhi <8114085+chenpeizhi@users.noreply.github.com>
…rom int to size_t)

Co-authored-by: chenpeizhi <8114085+chenpeizhi@users.noreply.github.com>
Copilot AI changed the title [WIP] Bump deps/fbitset from 1f1a3db to c3ca474 Fix libparenth compatibility with fbitset c3ca474 (Size type change from int to size_t) Nov 10, 2025
Copilot AI requested a review from chenpeizhi November 10, 2025 00:13
@chenpeizhi
Copy link
Contributor

@copilot You should untrack _codeql_build_dir and any other build artifacts.

Co-authored-by: chenpeizhi <8114085+chenpeizhi@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 10, 2025

@copilot You should untrack _codeql_build_dir and any other build artifacts.

Done in commit 536fed7. Untracked _codeql_build_dir and added /_codeql_build_dir/ to .gitignore.

@chenpeizhi chenpeizhi marked this pull request as ready for review November 10, 2025 00:20
@chenpeizhi chenpeizhi merged commit 05b3e37 into dependabot/submodules/deps/fbitset-c3ca474 Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants