Skip to content

Conversation

@mondus
Copy link
Member

@mondus mondus commented Oct 22, 2025

Licence link requires permalink

@ptheywood
Copy link
Member

ptheywood commented Oct 22, 2025

or justmove the file to /licence.md instead of download/licence.md? (or licence/index.md?) so it works with and without a trailing slash?

You've also used the brittish spelling for the permalink where as we'd decided to switch to the american version for consistency ( 😢 )

The CLA page might be having similar permalink issues which is more of a big deal and we should check, the bots use a trailing slash iirc

@mondus
Copy link
Member Author

mondus commented Oct 22, 2025

@ptheywood I forgot what we agreed for the links as you already have these in the PR for the main code. How about I use.

  • downloads\cla
  • downloods\license

Or if the CLA is alreayd linking to a specifci link then option 2 is

  • cla\
  • downloads\license\

@ptheywood
Copy link
Member

needs to be cla/ for the bots without changes to both vis repo and main repo again as that was what we'd agreed in the meeting (cla is not related to downloading)

license I don't mind the path for, we just (reluctantly) agreed to use the americanised spelling for consistency. We can add a redirect (via a html/js redirect unfortuantely) if we want to take licence -> license.

With and without the trailing slash is probably preferred.

@mondus
Copy link
Member Author

mondus commented Oct 22, 2025

Option 2 implemented.

Copy link
Member

@ptheywood ptheywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • licence is still used in the text in a number of places
  • the link to ./licence is still in use on the download/index.md which is now a dead link (should be ./license)
  • about/index.md still says:

    FLAME GPU 2 is available under the permissive MIT licence. For commercial consultancy using the software please contact us.

Co-authored-by: Peter Heywood <peethwd@gmail.com>
@mondus mondus merged commit 41a41f8 into master Oct 22, 2025
2 checks passed
@mondus mondus deleted the licence_fix branch October 22, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants