Skip to content

Conversation

@Steve-Mcl
Copy link
Contributor

Description

Consolidates dynamicChartOptions array into a singular row by calling this.chart.getOption()

Related Issue(s)

closes #2012

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl requested a review from colinl January 18, 2026 15:20
@Steve-Mcl
Copy link
Contributor Author

@colinl - does this make sense to you? See any issues with consolidating the chart options?

@colinl
Copy link
Collaborator

colinl commented Jan 20, 2026

It is difficult for me to see the complete picture as I only have a phone.
Does it work if you make a series of updates to a chart on a page that is not being viewed, and then switch to the page with it on?

@Steve-Mcl
Copy link
Contributor Author

It is difficult for me to see the complete picture as I only have a phone. Does it work if you make a series of updates to a chart on a page that is not being viewed, and then switch to the page with it on?

The array is still present and does get populated so long as there is no chart object. Once there is a chart object, the changes should be applied and consolidated. That's the theory anyhow.

I don't have time to dig further and do any manual testing so this will sit here for a while Colin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dynamic Chart options grow unrestricted

3 participants