Skip to content

Stop chart dynamicChartOptions array growing unrestricted #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Steve-Mcl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stop chart dynamicChartOptions array growing unrestricted #2013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions ui/src/widgets/ui-chart/UIChart.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,13 +188,16 @@
if (!updates) {
return
}
// merge the updates into the chart
if (updates.chartOptions) {
// merge the updates into the chart
if (this.chart) {
this.chart.setOption(updates.chartOptions)
// consolidate the options applied this session
this.dynamicChartOptions = [this.chart.getOption()]
} else {
// add these options to the array of previous updates received this session
this.dynamicChartOptions.push(updates.chartOptions)
}
// add these options to the array of previous updates received this session
this.dynamicChartOptions.push(updates.chartOptions)
}
},
generateChartOptions () {
Expand Down Expand Up @@ -748,10 +751,10 @@
updateYAxisLimits (options) {
if (this.hasData && this.props.xAxisType !== 'radial') {
if (!Object.hasOwn(this.props, 'ymin') || this.props.ymin === '' || typeof this.props.ymin === 'undefined') {
options.yAxis[0].min = axisHelper.getAxisMin // set sensible y-limits

Check warning on line 754 in ui/src/widgets/ui-chart/UIChart.vue

View workflow job for this annotation

GitHub Actions / build / Build on 20 

Caution: `axisHelper` also has a named export `getAxisMin`. Check if you meant to write `import {getAxisMin} from './helpers/axis.helper'` instead
}
if (!Object.hasOwn(this.props, 'ymax') || this.props.ymax === '' || typeof this.props.ymax === 'undefined') {
options.yAxis[0].max = axisHelper.getAxisMax // set sensible y-limits

Check warning on line 757 in ui/src/widgets/ui-chart/UIChart.vue

View workflow job for this annotation

GitHub Actions / build / Build on 20 

Caution: `axisHelper` also has a named export `getAxisMax`. Check if you meant to write `import {getAxisMax} from './helpers/axis.helper'` instead
}
}
},
Expand Down