refactor(website): migrate "compare side-by-side" to React #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR migrates the "compare side-by-side" view from Astro to React, improving code organization and testability while maintaining the same functionality.
Key changes:
- Extracted data display logic into a new React component (
GenericCompareSideBySideDataDisplay) - Added comprehensive end-to-end tests for the compare side-by-side page
- Refactored common test helper methods into the base
ViewPageclass to reduce duplication
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| website/tests/helpers.ts | Added test configuration for influenzaA and influenzaB organisms |
| website/tests/e2e.fixture.ts | Added CompareSideBySidePage fixture for e2e tests |
| website/tests/compareSideBySide.spec.ts | New test file with comprehensive coverage for compare side-by-side functionality |
| website/tests/ViewPage.ts | Extracted shared helper methods for lineage and mutation field interactions |
| website/tests/CompareVariantsPage.ts | Refactored to use shared helper methods from ViewPage |
| website/tests/CompareToBaselinePage.ts | Refactored to use shared helper methods from ViewPage |
| website/tests/CompareSideBySidePage.ts | New page object implementing interactions with the compare side-by-side view |
| website/src/components/views/compareSideBySide/GenericCompareSideBySidePage.astro | Simplified by delegating data display to React component |
| website/src/components/views/compareSideBySide/GenericCompareSideBySideDataDisplay.tsx | New React component containing migrated data display logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
website/src/components/views/compareSideBySide/GenericCompareSideBySideDataDisplay.tsx
Outdated
Show resolved
Hide resolved
Base automatically changed from
965-migrate-compare-to-baseline-to-react
to
main
December 16, 2025 10:34
fengelniederhammer
force-pushed
the
973-migrate-compare-side-by-side-to-react
branch
from
8a25624 to
370843f
Compare
fengelniederhammer
force-pushed
the
973-migrate-compare-side-by-side-to-react
branch
from
370843f to
a23a26a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #973
Summary
Screenshot
PR Checklist
- [ ] All necessary documentation has been adapted.