fix: Db2 fixes for padded char identification and default IfNull replacement token#1641
Open
fix: Db2 fixes for padded char identification and default IfNull replacement token#1641
Conversation
Collaborator
Author
|
I've put this back to draft while I move some dependent changes from this PR to new issue #1661 |
Collaborator
Author
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
We had a customer with issues on Db2 with a CHAR padded primary key.
To fix this I needed to resolve part of issue 1470, although only for Db2 so this PR does NOT close that issue. Unfortunately the fix only covers table level validations. There does not appear to be a way to get the raw data type for a custom query via the IBM Db2 driver.
The small changes to files below are to remove deprecation warnings when customers run DVT, they should not change functionality:
FutureWarning: Series.view is deprecated and will be removed in a future version. Use ``astype`` as an alternative to change the dtype.FutureWarning: A value is trying to be set on a copy of a DataFrame or Series through chained assignment using an inplace method.Issues to be closed
Closes #1638
Checklist
CONTRIBUTINGGuide.tests/local_check.shscript)