Skip to content

fix: Db2 fixes for padded char identification and default IfNull replacement token#1641

Open
nj1973 wants to merge 22 commits intodevelopfrom
1470-db2-char-padded-pks
Open

fix: Db2 fixes for padded char identification and default IfNull replacement token#1641
nj1973 wants to merge 22 commits intodevelopfrom
1470-db2-char-padded-pks

Conversation

@nj1973
Copy link
Collaborator

@nj1973 nj1973 commented Jan 12, 2026

Description of changes

We had a customer with issues on Db2 with a CHAR padded primary key.

To fix this I needed to resolve part of issue 1470, although only for Db2 so this PR does NOT close that issue. Unfortunately the fix only covers table level validations. There does not appear to be a way to get the raw data type for a custom query via the IBM Db2 driver.

The small changes to files below are to remove deprecation warnings when customers run DVT, they should not change functionality:

  • operations.py: FutureWarning: Series.view is deprecated and will be removed in a future version. Use ``astype`` as an alternative to change the dtype.
  • combiner.py: FutureWarning: A value is trying to be set on a copy of a DataFrame or Series through chained assignment using an inplace method.

Issues to be closed

Closes #1638

Checklist

  • I have followed the CONTRIBUTING Guide.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated any relevant documentation to reflect my changes, if applicable
  • I have added unit and/or integration tests relevant to my change as needed
  • I have already checked locally that all unit tests and linting are passing (use the tests/local_check.sh script)
  • I have manually executed end-to-end testing (E2E) with the affected databases/engines

@nj1973 nj1973 linked an issue Jan 12, 2026 that may be closed by this pull request
@nj1973 nj1973 marked this pull request as ready for review January 14, 2026 10:42
@nj1973 nj1973 mentioned this pull request Jan 27, 2026
@pull-request-size pull-request-size bot added size/M and removed size/L labels Jan 30, 2026
@nj1973 nj1973 marked this pull request as draft January 30, 2026 13:33
@nj1973 nj1973 removed the request for review from sundar-mudupalli-work January 30, 2026 13:34
@nj1973
Copy link
Collaborator Author

nj1973 commented Jan 30, 2026

I've put this back to draft while I move some dependent changes from this PR to new issue #1661

@nj1973 nj1973 marked this pull request as ready for review February 3, 2026 11:29
@nj1973
Copy link
Collaborator Author

nj1973 commented Feb 6, 2026

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Db2 row validation of test col_char_2 columns fails

1 participant