tsconfig: add merged internal path aliases for myWorld-client/react #60
Conversation
|
Is the idea with the |
No, we can have several releases of the template before 7.4 is released. Can we keep the line being removed to keep compatibility with pre 7.4 versions? Expectation is that people should be able to continue using (and pull&merge) the template with 7.2 or 7.3 even after 7.4 is released... |
luiscamachopt
left a comment
luiscamachopt
left a comment
There was a problem hiding this comment.
I think we need to discuss options for this better
| "@internal/hooks": ["../core/client/hooks"], | ||
| "@internal/uiComponents/react": ["../core/client/uiComponents/react"] |
There was a problem hiding this comment.
This looks quite awkward, sounds like we should reorganise the code in core for 7.4 to a more standard pattern(keeping existing imports working) and get more straightforward configuration?
There was a problem hiding this comment.
A single entry point to match the single import path would make sense, I think. Maybe a myWorld-react.js like we have myWorld-client.js?
There was a problem hiding this comment.
In 7.4, I think we need to keep myWorld-client.js for 7.4. I am curious about the change added to 7.4 that would require this change.
We can have both. I'll add a comment to |
mstrong98
left a comment
mstrong98
left a comment
There was a problem hiding this comment.
Thanks Dan, I think we need to revisit the changes made in 7.4 for this.
This PR adds the
tsconfig.core.jsonchanges from https://github.com/IQGeo/myworld-product-core/pull/2060.The
myWorld-client/reactimport alias is comprised of two separately exported modules from core:core/client/hooksandcore/client/uiComponents/react.compilerOptions.pathsdoesn't support merging two separate modules, so an ambient module declaration was added instead. This declaration references@internal/hooksand@internal/uiComponents/react, both of which need to be aliased in the consuming project.