Skip to content

tsconfig: add merged internal path aliases for myWorld-client/react #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Daniel-Knights wants to merge 1 commit into
base: dev
Choose a base branch
from
+4 −2
Open

tsconfig: add merged internal path aliases for myWorld-client/react #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,17 @@
"myWorld/*": ["../core/client/*"],
"myWorld-base": ["../core/client/myWorld-client-namespace.js"],
"myWorld-client": ["../core/client/myWorld-client-namespace.js"],
"myWorld-client/react": ["../core/client/uiComponents/react"],
"myWorld-native-services": ["../core/native/native-client.js"],
"modules/dev_tools/*": ["./dev_tools/public/*"],
"modules/vector_tile_styles/*": ["./vector_tile_styles/public/*"],
"images/*": ["../core/client/images/*"],
"config-shared": ["../core/config/shared"],
"config-settings": ["../core/config/config-settings.js"],
"modules/custom/*": ["./custom/public/*"],
"modules/comms/*": ["./comms/public/*"]
"modules/comms/*": ["./comms/public/*"],
// These are merged into `myWorld-client/react` in `dev_tools/typings/ambient.d.ts`
"@internal/hooks": ["../core/client/hooks"],
"@internal/uiComponents/react": ["../core/client/uiComponents/react"]
Comment on lines +17 to +18
Copy link
Contributor

@luiscamachopt luiscamachopt Jun 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks quite awkward, sounds like we should reorganise the code in core for 7.4 to a more standard pattern(keeping existing imports working) and get more straightforward configuration?

Copy link
Contributor Author

@Daniel-Knights Daniel-Knights Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A single entry point to match the single import path would make sense, I think. Maybe a myWorld-react.js like we have myWorld-client.js?

Copy link
Contributor

@mstrong98 mstrong98 Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 7.4, I think we need to keep myWorld-client.js for 7.4. I am curious about the change added to 7.4 that would require this change.

}
}
}