Added options to configure token type claim.#84
Open
s3rius wants to merge 2 commits intoIndominusByte:masterfrom
Open
Added options to configure token type claim.#84s3rius wants to merge 2 commits intoIndominusByte:masterfrom
s3rius wants to merge 2 commits intoIndominusByte:masterfrom
Conversation
Signed-off-by: Pavel Kirilin <win10@list.ru>
Closed
s3rius
force-pushed
the
feature/token_types
branch
from
1deb9e6 to
880d225
Compare
Author
|
@IndominusByte, while writing tests for this request I found out that some of your tests depend on configuration loaded by previous tests. |
Signed-off-by: Pavel Kirilin <win10@list.ru>
s3rius
force-pushed
the
feature/token_types
branch
from
880d225 to
cee8d2f
Compare
|
Is it possible to merge this PR? |
Author
|
@leonardovettulo, I've tried to contact the maintainer, but I couldn't find his contacts. If someone knows how to reach him and tell to look at this PR, it would be super great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, you did a super cool library, but I couldn't use it in our ecosystem.
These options are here to help this library to be more generic.
In many cases services built with
FastAPIare used as micro services that integrated in existing systems with existing authentication mechanisms.I faced an issue that JWTs that used in our backend have custom type claims, so I added these options to be able
to adjust this library nicely.
Signed-off-by: Pavel Kirilin win10@list.ru