Skip to content

RXR-2888: skip in case of fit error and add options to reduce precision#34

Merged
dominic-irx merged 9 commits intomainfrom
RXR-2888
Feb 2, 2026
Merged

RXR-2888: skip in case of fit error and add options to reduce precision#34
dominic-irx merged 9 commits intomainfrom
RXR-2888

Conversation

@dominic-irx
Copy link
Contributor

@dominic-irx dominic-irx commented Dec 2, 2025

This PR now does two things:

  1. skips an encounter in case of fit error
  2. Adds option to reduce precision of fit, to minimize fit errors (reltol in .fit_options).

@dominic-irx dominic-irx changed the title RXR-2888: add dose compartments input [WIP] RXR-2888: add dose compartments input Dec 2, 2025
@dominic-irx dominic-irx changed the title [WIP] RXR-2888: add dose compartments input RXR-2888: skip in case of fit error and add options to reduce precision Dec 3, 2025
@dominic-irx dominic-irx marked this pull request as ready for review December 3, 2025 22:53
@mccarthy-m-g
Copy link
Collaborator

@dominic-irx For the .fit_options argument, could we make it take a fit_options() function as input like we're doing for .stats_summ_options (stats_summ_options()) and .vpc_options (vpc_options ()).

The benefit is that we get clearer documentation on what's available, and we get input validation with nice error messages.

Merge commit '4127c214a4857777a1e3a6554c0c6f9215ee16c5'

#Conflicts:
#	R/calculate_stats.R
#	R/run_eval_core.R
@mccarthy-m-g
Copy link
Collaborator

I fixed merge conflicts and added a fit_options() function to use as input to .fit_options. The syntax looks like .fit_options = fit_options(reltol = 1e-04) now.

Copy link
Contributor

@roninsightrx roninsightrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dominic-irx dominic-irx merged commit ea8242e into main Feb 2, 2026
2 checks passed
@dominic-irx dominic-irx deleted the RXR-2888 branch February 2, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants