Conversation
…esn't already exist locally os.path.samefile can't be used with a non-existent file, which this commit avoids.
…tible manner, update dependencies
BREAKING CHANGE:
ratelimit library can exceed the set limit and lacks type annotations. Switching to limits solves both deficiencies.
…h the real argument names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds stricter type annotations to parts that Proxyshop uses. The aim of this PR is to ultimately enable stricter type annotation of Proxyshop. Many parts of Omnitils still don't conform with strict type annotations even after this change. I made the typing while using Pyright, so I'm not entirely sure if the typing works well with Mypy's strict mode as well. My previous PR, #8, is also included in order to make it easier for myself to provide development builds while waiting for your feedback. Let me know if you want that removed or any other changes to be made.
7.10.2025
Replaced reatelimit dependency with limits because the latter has more reliable limiting and type annotations.