Skip to content

Adding options for full width and padding for text container#82

Open
Chojecki wants to merge 3 commits intoJoran-Dob:mainfrom
TalkOutTech:main
Open

Adding options for full width and padding for text container#82
Chojecki wants to merge 3 commits intoJoran-Dob:mainfrom
TalkOutTech:main

Conversation

@Chojecki
Copy link

Description

I didn't find a way to add padding or make text container full width. So now SubtitleTextView can take extra arguments to set it.

class SubtitleWrapper extends StatelessWidget {
  const SubtitleWrapper({
    required this.videoChild,
    required this.subtitleController,
    required this.videoPlayerController,
    super.key,
    this.subtitleStyle = const SubtitleStyle(),
    this.backgroundColor,
    this.fullWidth = false,
    this.padding,
  });
  final Widget videoChild;
  final SubtitleController subtitleController;
  final VideoPlayerController videoPlayerController;
  final SubtitleStyle subtitleStyle;
  final Color? backgroundColor;
  final bool fullWidth; <-- new thing
  final double? padding; <-- new thing

... rest of the code

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant