Skip to content

Check subprocess exit and tidy command line generation #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samebdon merged 4 commits into from
Jan 28, 2026
Merged

Check subprocess exit and tidy command line generation #248

samebdon merged 4 commits into from
Jan 28, 2026

Conversation

@jgrg
Copy link
Contributor

@jgrg jgrg commented Jan 28, 2026

  • Checks the exit status of hetmers and extract_kmer_pairs when run.
  • Fixes name of hetmers and extract_kmer_pairs in their help messages.

@samebdon
Copy link
Collaborator

samebdon commented Jan 28, 2026

Wheel failing to build, looks like we might need to specify packaging>=24.2 in the build yaml or the pyproject.toml

@jgrg
Copy link
Contributor Author

jgrg commented Jan 28, 2026

We could probably drop Python 3.9 from builds. It is now "end of life".

@samebdon samebdon self-requested a review January 28, 2026 14:01
@samebdon samebdon merged commit 765a90c into KamilSJaron:master Jan 28, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samebdon samebdon samebdon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jgrg @samebdon