[WB-1998.2] Migrate color to semanticColor in perseus#3246
Open
jandrade wants to merge 4 commits intowb-color2scfrom
Open
[WB-1998.2] Migrate color to semanticColor in perseus#3246jandrade wants to merge 4 commits intowb-color2scfrom
jandrade wants to merge 4 commits intowb-color2scfrom
Conversation
added 3 commits
February 11, 2026 16:35
…olor` tokens instead of the now deprecated `color` tokens.
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
|
Size Change: +108 B (+0.02%) Total Size: 485 kB
ℹ️ View Unchanged
|
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (ff72172) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3246If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3246If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3246 |
jandrade
commented
Feb 12, 2026
| iconInactive: { | ||
| border: "2px solid transparent", | ||
| backgroundColor: color.offBlack8, | ||
| backgroundColor: semanticColor.core.background.neutral.subtle, |
Member
Author
There was a problem hiding this comment.
| iconActive: { | ||
| border: `2px solid ${semanticColor.core.border.knockout.default}`, | ||
| backgroundColor: color.offBlack64, | ||
| backgroundColor: semanticColor.core.background.neutral.default, |
Member
Author
There was a problem hiding this comment.
| borderStyle: "solid", | ||
| borderWidth: 1, | ||
| borderColor: color.offBlack50, | ||
| borderColor: semanticColor.core.border.neutral.default, |
Member
Author
There was a problem hiding this comment.
Comment on lines
+11
to
+13
| // TODO(WB-2160): Update these to use the new semanticColor tokens, and use the | ||
| // new tokenValue() function to get the raw value of the token. This is | ||
| // necessary because graphie only supports raw CSS colors. |
Member
Author
There was a problem hiding this comment.
note: Left this comment as I'm planning to come back to this later. As you are aware, Graphie doesn't support CSS variable references, so I'm planning to do something like this:
BLUE: tokenValue(semanticColor.core.foreground.instructive.default), // outputs the HEX value of that token
| }, | ||
| overCharacterLimit: { | ||
| color: color.red, | ||
| color: semanticColor.core.foreground.critical.default, |
Member
Author
There was a problem hiding this comment.
| title: { | ||
| fontSize: 12, | ||
| color: color.offBlack64, | ||
| color: semanticColor.core.foreground.neutral.subtle, |
Member
Author
There was a problem hiding this comment.
| fill: | ||
| fillStyle === "white" | ||
| ? wbColor.white | ||
| ? semanticColor.core.background.base.default |
Member
Author
There was a problem hiding this comment.
|
|
||
| // Add a shadow to the marker to make it stand out from the image. | ||
| boxShadow: `0 8px 8px ${color.offBlack8}`, | ||
| boxShadow: boxShadow.mid, |
Member
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Migrates the Aphrodite styles in the perseus folder to the new
semanticColortokens.
This PR is part of the larger effort to migrate the Perseus codebase to use the
new
semanticColortokens.Documents for reference:
Implementation plan:
Issue: https://khanacademy.atlassian.net/browse/WB-1998
Test plan:
Verify that the components in perseus look correct.