Skip to content

Conversation

@fcladera
Copy link
Collaborator

@fcladera fcladera commented May 6, 2022

A PR to discuss what to add to the README.md. Do not merge yet.

@versatran01
Copy link
Collaborator

I have made some changes to the README in https://github.com/KumarRobotics/ouster_decoder/tree/unsafe
Do you want to retarget that? What's the best way to do this?

@fcladera
Copy link
Collaborator Author

fcladera commented May 6, 2022

I can copy the changes of 9d3a481 into this branch. Unfortunately, the commit also modifies src/decoder.cpp so I cannot cherry-pick it. Could you do rebase -i HEAD~2 in the unsafe branch to remove the changes in the README there?

Option b is to deal with the merge conflicts later.

@versatran01
Copy link
Collaborator

If you know how to do it for option a, just go ahead and do it.
Once the unsafe branch is sufficiently tested (probably today) I will merge it back to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants