Skip to content

Issue list default values shouldn't render in the detail views.#6807

Merged
labkey-klum merged 2 commits intodevelopfrom
fb_issue_53343
Jun 30, 2025
Merged

Issue list default values shouldn't render in the detail views.#6807
labkey-klum merged 2 commits intodevelopfrom
fb_issue_53343

Conversation

@labkey-klum
Copy link
Contributor

@labkey-klum labkey-klum commented Jun 27, 2025

Rationale

related issue: https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=53343

This was caused by a helper function which automatically set the visible state to true and readonly to false. It was used as a convenience for the update view and unfortunately got propagated to the detail view. I've deleted that variant so users have to be explicit when setting those states.

Related Pull Requests

LabKey/testAutomation#2525

Tasks

  • Manual Testing
  • Needs Automation
  • Verify Fix

@labkey-klum labkey-klum self-assigned this Jun 27, 2025
@labkey-klum labkey-klum requested a review from a team June 27, 2025 22:29
Copy link
Contributor

@labkey-adam labkey-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll pull it down and verify.

@labkey-adam
Copy link
Contributor

@labkey-klum I did a quick local verify, so I think you can consider this verified and manually tested... unless you or someone else had more in mind

@labkey-klum labkey-klum merged commit be8edbd into develop Jun 30, 2025
9 checks passed
@labkey-klum labkey-klum deleted the fb_issue_53343 branch June 30, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants