Skip to content

Issue list default values shouldn't render in the detail views. #6807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-klum merged 2 commits into from
Jun 30, 2025
Merged

Issue list default values shouldn't render in the detail views. #6807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b75111
Default values shouldn't render in detail views.
labkey-klum Jun 27, 2025
3971a02
Merge branch 'develop' into fb_issue_53343
labkey-klum Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions issues/src/org/labkey/issue/model/IssuePage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,11 +400,6 @@ private TableInfo getIssueTable(ViewContext context)
return _tableInfo;
}

public HtmlString renderColumn(DomainProperty prop, ViewContext context) throws IOException
{
return renderColumn(prop, context, true, false);
}

public HtmlString renderColumn(DomainProperty prop, ViewContext context, boolean visible, boolean readOnly) throws IOException
{
if (prop != null && shouldDisplay(prop, context.getContainer(), context.getUser()))
Expand Down
6 changes: 3 additions & 3 deletions issues/src/org/labkey/issue/view/detailView.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@
<tr><%=bean.renderLabel(bean.getLabel("Status", false))%><td><%=h(issue.getStatus())%></td></tr><%
for (DomainProperty prop : extraColumns)
{%>
<%=bean.renderColumn(prop, getViewContext())%><%
<%=bean.renderColumn(prop, getViewContext(), true, true)%><%
}%>

<%=unsafe(bean.renderAdditionalDetailInfo())%>
Expand Down Expand Up @@ -277,7 +277,7 @@
}
for (DomainProperty prop : column1Props)
{%>
<%=bean.renderColumn(prop, getViewContext())%><%
<%=bean.renderColumn(prop, getViewContext(), true, true)%><%
}%>
</table></td>
<td valign="top" width="33%"><table class="lk-fields-table">
Expand All @@ -290,7 +290,7 @@

for (DomainProperty prop : column2Props)
{%>
<%=bean.renderColumn(prop, getViewContext())%><%
<%=bean.renderColumn(prop, getViewContext(), true, true)%><%
}%>
</table></td>
</tr>
Expand Down
8 changes: 4 additions & 4 deletions issues/src/org/labkey/issue/view/updateView.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@

for (DomainProperty prop : column1Props)
{%>
<%=bean.renderColumn(prop, getViewContext())%><%
<%=bean.renderColumn(prop, getViewContext(), true, false)%><%
}%>
</table>
</td>
Expand Down Expand Up @@ -385,16 +385,16 @@
}
for (DomainProperty prop : column2Props)
{%>
<%=bean.renderColumn(prop, getViewContext())%><%
<%=bean.renderColumn(prop, getViewContext(), true, false)%><%
}%>
</table></td>
</tr>
<%=bean.renderColumn(propertyMap.get("assignedTo"), getViewContext(), bean.isVisible("assignedTo"), bean.isReadOnly("assignedTo"))%>
<%
for (DomainProperty prop : extraColumns)
{%>
<%=bean.renderColumn(prop, getViewContext())%><%
}%>
<%=bean.renderColumn(prop, getViewContext(), true, false)%><%
}%>
<tr>
<%=bean.renderLabel(bean.getLabel("Comment", bean.isInsert()))%>
<td colspan="3">
Expand Down