Skip to content

Conversation

@labkey-klum
Copy link
Contributor

@labkey-klum labkey-klum commented Aug 28, 2025

Rationale

tracking issue

For both DomainDescriptor and PropertyDescriptor the project field has a not null database constraint. Recent changes to stop holding onto Container instances broke some of this when the container was root. This just restores the prior behavior and also updates the data views panel to show something more helpful than an empty dialog when errors like this occur.

Related Pull Requests

Tasks 📍

@labkey-klum labkey-klum merged commit 8b4e280 into release25.7-SNAPSHOT Sep 3, 2025
6 of 7 checks passed
@labkey-klum labkey-klum deleted the 25.7_fb_issue_53630 branch September 3, 2025 21:59
@labkey-klum labkey-klum requested a review from Copilot September 3, 2025 23:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes non-null database constraint violations for the project field in DomainDescriptor and PropertyDescriptor classes, and improves error handling in the DataViewsPanel UI.

  • Modified getProject() methods to return the container itself when no project is available, ensuring the project field is never null
  • Enhanced error message display in DataViewsPanel to show specific exception details instead of generic "Failure" messages

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
PropertyDescriptor.java Updated getProject() to fallback to container when project is null
DomainDescriptor.java Updated getProject() to fallback to container when project is null
DataViewsPanel.js Improved error handling with descriptive failure messages

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants