Regression for manage views exception #2657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
labkey-tchad
approved these changes
Aug 29, 2025
Member
labkey-tchad
left a comment
labkey-tchad
left a comment
There was a problem hiding this comment.
One suggestion.
I think this is a fine home for this test though.
Comment on lines
172
to
175
| if (!getCustomizeView().isPanelExpanded()) | ||
| { | ||
| getViewsMenu().clickSubMenu(false, "Manage Views"); | ||
| } |
Member
There was a problem hiding this comment.
I don't think we want this to no-op if the customize view panel is open.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
tracking issue
This adds a simple regression test for 53630 by going to the site users table and opening the manage views page. I'm open to moving this test to a more appropriate class, it is independent of study. I could move it to the
DataViewsTestbut that is also study-based and one of those old style monolithic tests.Related Pull Requests