Issue 53063: Support "Aliquoted From" with space#7099
Conversation
| @NotNull Map<String, String> getImportAliases() throws IOException; | ||
|
|
||
| @NotNull | ||
| default Map<String, String> getImportAliasesIncludingAliquot() throws IOException |
There was a problem hiding this comment.
Add an issue number reference here? Or with one of these updates (not sure which is the most obvious), just so it's easier to find what's changed for this issue.
| { | ||
| Map<String, Object> result = super.updateRow(user, container, row, oldRow, allowOwner, retainCreation); | ||
|
|
||
| // add MaterialInput/DataInputs field from parent alias |
There was a problem hiding this comment.
I'm unclear why this wasn't necessary before. Can you enlighten me?
There was a problem hiding this comment.
There was a bug that row by row update using alias gets silently ignored. It's reproducible only from API, since our UI will never send the request using alias, and file import will never hit the row by row code. Due to its narrow repro, I didn't create a separate issue for it. In a way, one could argue ignoring import alias for query api update is per design, since this feature was called importAliases.
Rationale
"AliquotedFrom" is used as aliquot parent input column, similar to MaterialInputs/Type is used to indicate lineage parent. It's requested that user can alternatively use "Aliquoted From" with a space as the import column header. This PR updates various steps that checks for AliquotedFrom to also allow "Aliquoted From". The exception is with naming expression, where only ${AiquotedFrom} syntax is supported.
This PR also addresses Issue 53963: Cross-sample-type import gives incorrect row number in message for name expression problems.
Related Pull Requests
Changes
Tasks 📍
Verify FixManual Test plan