-
Notifications
You must be signed in to change notification settings - Fork 7
Issue 53063: Support "Aliquoted From" with space #7099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
516c267
042b81e
4320765
7aff2ef
2009b56
0075347
a94cbab
81efd9e
a5fb5ac
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1370,6 +1370,32 @@ else if (name != null) | |
| return dataRow; | ||
| } | ||
|
|
||
|
|
||
| @Override | ||
| protected Map<String, Object> updateRow(User user, Container container, Map<String, Object> row, @NotNull Map<String, Object> oldRow, boolean allowOwner, boolean retainCreation) | ||
| throws InvalidKeyException, ValidationException, QueryUpdateServiceException, SQLException | ||
| { | ||
| Map<String, Object> result = super.updateRow(user, container, row, oldRow, allowOwner, retainCreation); | ||
|
|
||
| // add MaterialInput/DataInputs field from parent alias | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm unclear why this wasn't necessary before. Can you enlighten me?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a bug that row by row update using alias gets silently ignored. It's reproducible only from API, since our UI will never send the request using alias, and file import will never hit the row by row code. Due to its narrow repro, I didn't create a separate issue for it. In a way, one could argue ignoring import alias for query api update is per design, since this feature was called importAliases. |
||
| try | ||
| { | ||
| Map<String, String> parentAliases = _dataClass.getImportAliases(); | ||
| for (String alias : parentAliases.keySet()) | ||
| { | ||
| if (row.containsKey(alias)) | ||
| result.put(parentAliases.get(alias), result.get(alias)); | ||
| } | ||
| } | ||
| catch (IOException e) | ||
| { | ||
| throw new RuntimeException(e); | ||
| } | ||
|
|
||
| return result; | ||
|
|
||
| } | ||
|
|
||
| @Override | ||
| protected Map<String, Object> _update(User user, Container c, Map<String, Object> row, Map<String, Object> oldRow, Object[] keys) throws SQLException, ValidationException | ||
| { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an issue number reference here? Or with one of these updates (not sure which is the most obvious), just so it's easier to find what's changed for this issue.