Skip to content

Shut down transaction caches when commit tasks throw exceptions#7220

Merged
labkey-jeckels merged 3 commits intorelease25.11-SNAPSHOTfrom
25.11_fb_schedulingPermissions
Nov 20, 2025
Merged

Shut down transaction caches when commit tasks throw exceptions#7220
labkey-jeckels merged 3 commits intorelease25.11-SNAPSHOTfrom
25.11_fb_schedulingPermissions

Conversation

@labkey-jeckels
Copy link
Contributor

Rationale

We can leak transaction caches if a PRECOMMIT task fails and the whole transaction is rolled back.

We now have a test that's doing this as part of its regular validation.

https://teamcity.labkey.org/buildConfiguration/LabKey_2511Release_External_Panorama_PanoramaAPostgres/3741228

Changes

  • Move the closing to a finally block

Tasks 📍

  • Manual Testing - N/A
  • Needs Automation

@labkey-jeckels labkey-jeckels requested a review from a team November 19, 2025 22:35
@labkey-jeckels labkey-jeckels self-assigned this Nov 19, 2025
@labkey-jeckels labkey-jeckels merged commit 6918fbf into release25.11-SNAPSHOT Nov 20, 2025
18 checks passed
@labkey-jeckels labkey-jeckels deleted the 25.11_fb_schedulingPermissions branch November 20, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants