Skip to content

Shut down transaction caches when commit tasks throw exceptions #7220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-jeckels merged 3 commits into from
Nov 20, 2025
Merged

Shut down transaction caches when commit tasks throw exceptions #7220

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
196da18
Avoid leaving connection in bad state after exception during precommi…
labkey-jeckels Nov 17, 2025
c8f1f66
Merge branch 'release25.11-SNAPSHOT' into 25.11_fb_schedulingPermissions
labkey-jeckels Nov 19, 2025
58d10a0
Ensure caches are closed regardless of success
labkey-jeckels Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions api/src/org/labkey/api/data/DbScope.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2385,12 +2385,17 @@ public void run(TransactionImpl transaction)
// Copy to avoid ConcurrentModificationExceptions, need to retain original order from LinkedHashMap
List<Runnable> tasks = new ArrayList<>(getRunnables(transaction).keySet());

for (Runnable task : tasks)
try
{
task.run();
for (Runnable task : tasks)
{
task.run();
}
}
finally
{
transaction.closeCaches();
}

transaction.closeCaches();
}

public <T extends Runnable> T add(TransactionImpl transaction, T task)
Expand Down
Loading