Improve failure behavior in AssayTransformImportUpdateTest#2510
Improve failure behavior in AssayTransformImportUpdateTest#2510labkey-jeckels merged 2 commits intodevelopfrom
Conversation
labkey-chrisj
left a comment
labkey-chrisj
left a comment
There was a problem hiding this comment.
I trust that this will work, but I'm curious to understand how 😅
| importPage.clickSaveAndFinish(); | ||
|
|
||
| waitAndClickAndWait(Locator.linkWithText("Assay upload RUNNING")); | ||
| waitAndClick(WAIT_FOR_JAVASCRIPT, Locator.linkWithText("Assay upload RUNNING"), WAIT_FOR_JAVASCRIPT); |
There was a problem hiding this comment.
This seems an acceptable change, but I'm curious as to how it serves to avoid the assertion?
waitAndClickAndWait wraps waitAndClick, the only difference is it passes in a longer wait for the page load
There was a problem hiding this comment.
It doesn't change the server-side behavior. That's addressed in the platform PR that's linked here.
This change simply makes the test fail after 10 seconds instead of 60 seconds if it doesn't see the link it expects. When it does, the failure triggers a thread dump on the server, which helps understand why it's taking so long to render. That thread dump helped me track down a deadlock-type problem.
labkey-jeckels
changed the title
2 participants
Rationale
Improve failure condition when AssayTransformImportUpdateTest fails to kill the job
Related Pull Requests
Changes