Skip to content

Improve failure behavior in AssayTransformImportUpdateTest #2510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-jeckels merged 2 commits into from
Jun 24, 2025
Merged

Improve failure behavior in AssayTransformImportUpdateTest #2510

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
381d57c
Shorten timeout to hopefully get a thread dump
labkey-jeckels Jun 17, 2025
044fafc
Merge branch 'develop' into fb_raceConditionKillingConnection
labkey-jeckels Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/org/labkey/test/tests/assay/AssayTransformImportUpdateTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ public void testCancelAsyncAssayTransformJob() throws Exception
Instant before = Instant.now();
importPage.clickSaveAndFinish();

waitAndClickAndWait(Locator.linkWithText("Assay upload RUNNING"));
waitAndClick(WAIT_FOR_JAVASCRIPT, Locator.linkWithText("Assay upload RUNNING"), WAIT_FOR_JAVASCRIPT);
Copy link
Contributor

@labkey-chrisj labkey-chrisj Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems an acceptable change, but I'm curious as to how it serves to avoid the assertion?
waitAndClickAndWait wraps waitAndClick, the only difference is it passes in a longer wait for the page load

Copy link
Contributor Author

@labkey-jeckels labkey-jeckels Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't change the server-side behavior. That's addressed in the platform PR that's linked here.

This change simply makes the test fail after 10 seconds instead of 60 seconds if it doesn't see the link it expects. When it does, the failure triggers a thread dump on the server, which helps understand why it's taking so long to render. That thread dump helped me track down a deadlock-type problem.

Copy link
Contributor

@labkey-chrisj labkey-chrisj Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

PipelineStatusDetailsPage pipelineStatusDetailsPage = new PipelineStatusDetailsPage(getDriver());
pipelineStatusDetailsPage.clickCancel();

Expand Down