Skip to content

Conversation

@labkey-tchad
Copy link
Member

Rationale

ConfigureSystemMaintenancePage.runMaintenanceTask assumes that it has opened a new window when it waits for the pipeline job to complete. FileContentUploadTest.testCalculateFileRootSize actually triggers the system maintenance twice without closing the window. The causes the test to fail intermittently as failing to wait for page loads often does.

java.lang.AssertionError: Incorrect job status expected:<COMPLETE> but was:<null>
  at org.junit.Assert.fail(Assert.java:89)
  at org.junit.Assert.failNotEquals(Assert.java:835)
  at org.junit.Assert.assertEquals(Assert.java:120)
  at org.labkey.test.pages.pipeline.PipelineStatusDetailsPage.assertStatus(PipelineStatusDetailsPage.java:125)
  at org.labkey.test.pages.pipeline.PipelineStatusDetailsPage.waitForStatus(PipelineStatusDetailsPage.java:139)
  at org.labkey.test.pages.pipeline.PipelineStatusDetailsPage.waitForComplete(PipelineStatusDetailsPage.java:182)
  at org.labkey.test.pages.pipeline.PipelineStatusDetailsPage.waitForComplete(PipelineStatusDetailsPage.java:170)
  at org.labkey.test.pages.admin.ConfigureSystemMaintenancePage.runMaintenanceTask(ConfigureSystemMaintenancePage.java:34)
  at org.labkey.test.tests.filecontent.FileContentUploadTest.testCalculateFileRootSize(FileContentUploadTest.java:367)

Rather that updating the test to close the window, we can make the page more robust by waiting for a page load when necessary.

Related Pull Requests

Changes

  • Wait for system maintenance page to load when rerunning the task

@labkey-tchad labkey-tchad requested review from a team and labkey-chrisj and removed request for a team August 8, 2025 23:50
@labkey-tchad labkey-tchad merged commit 435a498 into release25.7-SNAPSHOT Aug 11, 2025
8 checks passed
@labkey-tchad labkey-tchad deleted the 25.7_fb_waitForMaintenancePageLoad branch August 11, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants