Update components for conditional format testing#2685
Merged
labkey-chrisj merged 15 commits intodevelopfrom Sep 26, 2025
Merged
Update components for conditional format testing#2685labkey-chrisj merged 15 commits intodevelopfrom
labkey-chrisj merged 15 commits intodevelopfrom
Conversation
Contributor
labkey-danield
left a comment
labkey-danield
left a comment
There was a problem hiding this comment.
Looks ok.
Are you going to be adding tests here in testAutomation for the conditional format dialog?
Contributor
Author
My plan was to add those in the current test, and do verifications both in-app and in-lks |
labkey-danield
approved these changes
Sep 23, 2025
Comment on lines
+33
to
+44
| if (i==0) | ||
| { | ||
| setFirstCondition(filterCondition.getOperator()); | ||
| if (filterCondition.getValue() != null) | ||
| setFirstValue(filterCondition.getValue().toString()); | ||
| } | ||
| if (i==1) | ||
| { | ||
| setSecondCondition(filterCondition.getOperator()); | ||
| if (filterCondition.getValue() != null) | ||
| setSecondValue(filterCondition.getValue().toString()); | ||
| } |
Contributor
There was a problem hiding this comment.
Isn't this really just an if / else condition? Isn't the limit is two conditions at most? If i != 0 then you have to be setting the second one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This change makes minor changes to existing components to support better/easier testing of conditional formatting
Related Pull Requests
https://github.com/LabKey/limsModules/pull/1662
Changes
-make
DetailTableaware of format pills-make
GridRowaware of format pills-allow
ConditionalFormatDialogto take aConditionalFormat