-
Notifications
You must be signed in to change notification settings - Fork 9
Update components for conditional format testing #2685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f66e754
Add setter for ConditionalFormatPanel that takes a ConditionalFormat
labkey-chrisj 7982a0d
provide means for DetailTable and GridRow to be format-pill-aware
labkey-chrisj de9a7f8
Merge branch 'develop' into fb_conditional_format_apps
labkey-chrisj 087ad74
Merge branch 'develop' into fb_conditional_format_apps
labkey-chrisj c6de0c2
Merge branch 'develop' into fb_conditional_format_apps
labkey-danield f97ed03
Merge branch 'develop' into fb_conditional_format_apps
labkey-danield 90a9b1b
Merge branch 'develop' into fb_conditional_format_apps
labkey-danield b5b9a0a
Merge branch 'develop' into fb_conditional_format_apps
labkey-chrisj d79f40d
Merge branch 'develop' into fb_conditional_format_apps
labkey-chrisj 9967b90
getters for ConditionalFormatPanel
labkey-chrisj 497f0c1
get style for a grid value-wrapper
labkey-chrisj 8baf64f
Merge branch 'develop' into fb_conditional_format_apps
labkey-danield e64855b
Merge branch 'develop' into fb_conditional_format_apps
labkey-chrisj 0581250
avoid timing condition in DetailTable
labkey-chrisj 4e1a476
revert waits for field elements
labkey-chrisj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this really just an if / else condition? Isn't the limit is two conditions at most? If i != 0 then you have to be setting the second one.