-
Notifications
You must be signed in to change notification settings - Fork 1
Use a recent model development run that wasn't produced for CMIP #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Use a recent model development run that wasn't produced for CMIP #350
Conversation
NParsonsMO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree it runs and produces the requested output.
One copyright change requested.
Few other comments / queries.
NParsonsMO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gather from conversations at planning that it is OK to have the mip table number hard coded in, and I have no reason to believe that 0.0.25 is any worse than 0.0.9, so I will approve.
ehogan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mo-nikosbaltas 🥳
Please update the PR title to match the issue title (there is an extra "update" at the end of the PR title).
cylc vip -O metoffice -O unittest and cylc vip -O metoffice -O test both work for me 🥳
|
OFFICIAL
I had responded.
OFFICIAL
From: Emma Hogan ***@***.***>
Sent: 22 January 2026 18:32
To: MetOffice/CMEW ***@***.***>
Cc: Nikolaos Baltas ***@***.***>; Mention ***@***.***>
Subject: Re: [MetOffice/CMEW] Use a recent model development run that wasn't produced for CMIP (PR #350)
@ehogan commented on this pull request.
________________________________
In CMEW/app/unittest/kgo/test_updated_radiation_budget_recipe.yml<#350 (comment)>:
----
+#
@mo-nikosbaltas<https://github.com/mo-nikosbaltas> would it be possible for you to respond to this comment, please? 😊
—
Reply to this email directly, view it on GitHub<#350 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BNX4ZM6TFHSRVBLWLHPP4KT4IEJQTAVCNFSM6AAAAACSKRTAAOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMOJTHEZTGNBWGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
mo-nikosbaltas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted config-developer.yml
Closes #306
PR creation checklist for the developer
<issue_number>above ☝️ been replaced with the issue number?mainbeen selected as the base branch?<issue_number>_<short_description_of_feature>?good first issuelabel) been added to the PR?Climate Model Evaluation Workflow (CMEW)project been added to the PR?Definition of Done for the developer
docdirectory) related to the change been updated appropriately, N/A including the Quick Start section?PR creation checklist for the reviewer
<issue_number>above ☝️ been replaced with the issue number?mainbeen selected as the base branch?<issue_number>_<short_description_of_feature>?good first issuelabel) been added to the PR?Climate Model Evaluation Workflow (CMEW)project been added to the PR?Definition of Done for the reviewer
docdirectory) related to the change been updated appropriately, including the Quick Start section?