Skip to content

Conversation

@mo-nikosbaltas
Copy link
Collaborator

@mo-nikosbaltas mo-nikosbaltas commented Jan 20, 2026

Closes #306

PR creation checklist for the developer

  • Has <issue_number> above ☝️ been replaced with the issue number?
  • Has main been selected as the base branch?
  • Does the feature branch name follow the format <issue_number>_<short_description_of_feature>?
  • Does the text of the PR title exactly match with the text (not including the issue number) of the issue title?
  • Have appropriate reviewers been added to the PR (once it is ready for review)?
  • Has the PR been assigned to the developer(s)?
  • Have the same labels as on the issue (except for the good first issue label) been added to the PR?
  • Has the Climate Model Evaluation Workflow (CMEW) project been added to the PR?
  • Has the appropriate milestone been added to the PR?

Definition of Done for the developer

  • Does the change in this PR address the above issue / have all acceptance criteria been met?
  • Does the change in this PR follow the requirements in the wiki: Developer Guide (including copyrights)?
  • Have new tests related to the change been added?
  • Do all the GitHub workflow checks pass?
  • Do all the tests run locally and pass? (Note: the tests are not run by the GitHub workflow, see wiki: Run the tests locally)
  • Has the API documentation (e.g. docstrings in Python modules) related to the change been updated appropriately?
  • Has the user documentation (i.e. everything in the doc directory) related to the change been updated appropriately, N/A including the Quick Start section?
  • Do the HTML pages render correctly? (See wiki: Build the documentation locally)

PR creation checklist for the reviewer

  • Has <issue_number> above ☝️ been replaced with the issue number?
  • Has main been selected as the base branch?
  • Does the feature branch name follow the format <issue_number>_<short_description_of_feature>?
  • Does the text of the PR title exactly match with the text (not including the issue number) of the issue title?
  • Have appropriate reviewers been added to the PR (once it is ready for review)?
  • Has the PR been assigned to the developer(s)?
  • Have the same labels as on the issue (except for the good first issue label) been added to the PR?
  • Has the Climate Model Evaluation Workflow (CMEW) project been added to the PR?
  • Has the appropriate milestone been added to the PR?

Definition of Done for the reviewer

  • Does the change in this PR address the above issue / have all acceptance criteria been met?
  • Does the change in this PR follow the requirements in the wiki: Developer Guide (including copyrights)?
  • Have new tests related to the change been added?
  • Do all the GitHub workflow checks pass?
  • Do all the tests run locally and pass? (Note: the tests are not run by the GitHub workflow, see wiki: Run the tests locally)
  • Has the API documentation (e.g. docstrings in Python modules) related to the change been updated appropriately?
  • Has the user documentation (i.e. everything in the doc directory) related to the change been updated appropriately, including the Quick Start section?
  • Do the HTML pages render correctly? (See wiki: Build the documentation locally)

@mo-nikosbaltas mo-nikosbaltas self-assigned this Jan 20, 2026
@mo-nikosbaltas mo-nikosbaltas added the configure Anything related to configuration label Jan 20, 2026
@mo-nikosbaltas mo-nikosbaltas changed the title 306 use a recent model development run that wasnt produced for cmip update use a recent model development run that wasnt produced for cmip update Jan 20, 2026
Copy link
Collaborator

@NParsonsMO NParsonsMO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree it runs and produces the requested output.

One copyright change requested.

Few other comments / queries.

@NParsonsMO NParsonsMO changed the title use a recent model development run that wasnt produced for cmip update Use a recent model development run that wasnt produced for cmip update Jan 21, 2026
@NParsonsMO NParsonsMO changed the title Use a recent model development run that wasnt produced for cmip update Use a recent model development run that wasnt produced for CMIP update Jan 21, 2026
@NParsonsMO NParsonsMO changed the title Use a recent model development run that wasnt produced for CMIP update Use a recent model development run that wasn't produced for CMIP update Jan 21, 2026
NParsonsMO
NParsonsMO previously approved these changes Jan 21, 2026
Copy link
Collaborator

@NParsonsMO NParsonsMO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gather from conversations at planning that it is OK to have the mip table number hard coded in, and I have no reason to believe that 0.0.25 is any worse than 0.0.9, so I will approve.

Copy link
Member

@ehogan ehogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mo-nikosbaltas 🥳

Please update the PR title to match the issue title (there is an extra "update" at the end of the PR title).

cylc vip -O metoffice -O unittest and cylc vip -O metoffice -O test both work for me 🥳

@mo-nikosbaltas mo-nikosbaltas changed the title Use a recent model development run that wasn't produced for CMIP update Use a recent model development run that wasn't produced for CMIP Jan 22, 2026
@mo-nikosbaltas mo-nikosbaltas requested a review from ehogan January 22, 2026 17:53
@mo-nikosbaltas
Copy link
Collaborator Author

mo-nikosbaltas commented Jan 22, 2026 via email

Copy link
Collaborator Author

@mo-nikosbaltas mo-nikosbaltas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted config-developer.yml

@alistairsellar alistairsellar removed their request for review January 23, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

configure Anything related to configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use a recent model development run that wasn't produced for CMIP

5 participants