🔥 Deprecate internal class ServiceMatcher, merge only used function in MyParcelComApi#235
Merged
yoerriwalstra merged 2 commits intodevelopfrom Mar 4, 2025
Conversation
yoerriwalstra
approved these changes
Mar 4, 2025
yoerriwalstra
deleted the
improvement/injectable-service-matcher-alternative
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the service matching logic in the MyParcelCom API SDK by removing the
ServiceMatcherclass and integrating its functionality directly into theMyParcelComApiclass. The changes simplify the codebase and improve maintainability.Refactoring and code simplification:
src/MyParcelComApi.php: Removed theServiceMatcherclass and moved thematchesDeliveryMethodmethod into theMyParcelComApiclass. ThegetServicesmethod now uses the newmatchesDeliveryMethodmethod directly. [1] [2]src/Shipments/ServiceMatcher.php: Deleted the entireServiceMatcherclass, as its functionality has been integrated into theMyParcelComApiclass.tests/Unit/Shipments/ServiceMatcherTest.php: Removed the unit tests for theServiceMatcherclass, as the class no longer exists.