Skip to content

Conversation

@StoneMoe
Copy link

@StoneMoe StoneMoe commented Aug 21, 2022

Hi, Simplified Chinese native speaker here.
This PR contains:

  1. Full Simplified Chinese(zh-cn.json) translation
  2. Fix machine translating errors as many as possible for zh-cn.json
  3. Formatting zh-cn.json to match key order and format with baseline en.js
  4. Fix encoding issue in CleanJSON.py
  5. Add convenient features for translating in CleanJSON.py
  6. Fix incorrect ISO 639-1 code in localeCode field

Future: will keep working on proofread, translating, and error fix for zh-cn.

@StoneMoe StoneMoe marked this pull request as ready for review August 22, 2022 09:13
@ProbablePrime
Copy link
Contributor

Thanks for your contribution @StoneMoe! The translation looks good.

As for the python changes, @kazu0617 and @Xqua would you mind reviewing the python changes as you two have been most active on the python script

@ProbablePrime
Copy link
Contributor

We'll also need to ratify this with #662 before it can be merged so this one and #662 will stay open till that can happen

@StoneMoe
Copy link
Author

StoneMoe commented Aug 23, 2022

Thanks for response ProbablePrime :D
Hope better translation can happen soon since there is still a huge VR community can barely speak English.
And some of them start looking for a successor of VRChat recently.

I'll keep updating zh-cn.json for better translation quality before merge.

@kazu0617
Copy link
Contributor

Thanks for your contribution @StoneMoe! The translation looks good.

As for the python changes, @kazu0617 and @Xqua would you mind reviewing the python changes as you two have been most active on the python script

I think no probrem in Python, but i think already fallback to en-us in neos client. it changes works for translators.

So after merge this pr, plz set actions for auto ci/cd to other language when en-US commit works.

"相机" for "camera/Physical camera" & "摄像机" for "Streaming camera"
@ProbablePrime
Copy link
Contributor

It is still unclear to me which zh-cn translation is the more up to date one based on the comments here.

This is still low urgency as updates are still paused for the moment, but I'd like to get clarity on it when we can.

Thank you.

@StoneMoe
Copy link
Author

StoneMoe commented Feb 2, 2023

It is still unclear to me which zh-cn translation is the more up to date one based on the comments here.

This is still low urgency as updates are still paused for the moment, but I'd like to get clarity on it when we can.

Thank you.

Hi, great to see some progress is happening.
I'm contacting @metameqa via WeChat for further confirming now.

@StoneMoe
Copy link
Author

StoneMoe commented Feb 2, 2023

@ProbablePrime after some discussion, @metameqa and I decided to merge this PR into #662
@metameqa will work on this these days
I will close this PR after everything is done.

@StoneMoe
Copy link
Author

Closed by #662

@StoneMoe StoneMoe closed this Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants