Add missing source files referenced by PDB.

[tom-englert]

Fix for NuGet/Home#304

[dnfclas]

Hi @tom-englert, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

[dnfclas]

@tom-englert, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

[yishaigalatzer]

Sweet, thanks for sticking through this long process! We will take a look

CC @tmat

[yishaigalatzer]

@tom-englert Can you please add a test case ?

[tom-englert]

@yishaigalatzer this is just wrapping existing stuff that is already unit tested (it does not make sense unit-testing DisSymReader here). I'm not the friend of adding dummy unit tests just for the sake of having a unit test.
This would need some integration test, but I see no framework for this.

[yishaigalatzer]

Completely agree. Command line tests in nuget.client repo are where the integration tests live.

Yishai

---

From: Tom Englertmailto:notifications@github.com
Sent: ‎10/‎17/‎2015 1:13 AM
To: NuGet/NuGet2mailto:NuGet2@noreply.github.com
Cc: Yishai Galatzermailto:yigalatz@microsoft.com
Subject: Re: [NuGet2] Add missing source files referenced by PDB. (#19)

@yishaigalatzerhttps://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fyishaigalatzer&data=01%7c01%7cyigalatz%40microsoft.com%7c092e355146064ee4e6c408d2d6cae03c%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=yq2umMiCT0X3XoBpH%2ft9H%2fKKMxjZNDrqB8DdLteJHjY%3d this is just wrapping existing stuff that is already unit tested (it does not make sense unit-testing DisSymReader here). I'm not the friend of adding dummy unit tests just for the sake of having a unit test.
This would need some integration test, but I see no framework for this.

—
Reply to this email directly or view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fNuGet%2fNuGet2%2fpull%2f19%23issuecomment-148894887&data=01%7c01%7cyigalatz%40microsoft.com%7c092e355146064ee4e6c408d2d6cae03c%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=DOp0JoPJw05tE3KLYxojQiPFTIVqZT57EvhUM4xpjmc%3d.

[yishaigalatzer]

@tmat - When do you plan to turn the RC into RTM?
@tom-englert - This need to go into the 2.10 branch rather than 2.9 branch

[tmat]

Within a week or so.

[tom-englert]

replaced with #23 based on 2.10 branch